diff options
author | Richard Ipsum <richard.ipsum@codethink.co.uk> | 2015-03-30 13:34:40 +0000 |
---|---|---|
committer | Baserock Gerrit <gerrit@baserock.org> | 2015-04-01 10:55:17 +0000 |
commit | a69b342f542f4895ef2bfd9f18a0e56d38b4bc7d (patch) | |
tree | ad927a042ce55d9514189c80345b49733ad2be5c | |
parent | bb3fa0e026b1bab96b4bbbcb1920efcf5f995f37 (diff) | |
download | definitions-a69b342f542f4895ef2bfd9f18a0e56d38b4bc7d.tar.gz |
Fix: strip 'network=' from NIC_CONFIG
Also ensure NIC_CONFIG begins with 'network=', 'bridge=' or is 'user'
Change-Id: I3bcbd25eb2c9a05b7fa276697f97a1080cb0316e
-rwxr-xr-x | kvm.check | 14 |
1 files changed, 11 insertions, 3 deletions
@@ -129,14 +129,22 @@ class KvmPlusSshCheckExtension(morphlib.writeexts.WriteExtension): def name(nic_entry): if ',' in nic_entry: - # NETWORK_NAME,mac=12:34,model=e1000... - return nic_entry[:nic_entry.find(',')] + # network=NETWORK_NAME,mac=12:34,model=e1000... + return nic_entry[:nic_entry.find(',')].lstrip('network=') else: - return nic_entry # NETWORK_NAME + return nic_entry.lstrip('network=') # NETWORK_NAME if 'NIC_CONFIG' in os.environ: nics = os.environ['NIC_CONFIG'].split() + for n in nics: + if not (n.startswith('network=') + or n.startswith('bridge=') + or n == 'user'): + raise cliapp.AppException('malformed NIC_CONFIG: %s\n' + " (expected 'bridge=BRIDGE' 'network=NAME'" + " or 'user')" % n) + # --network bridge= is used to specify a bridge # --network user is used to specify a form of NAT # (see the virt-install(1) man page) |