summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoerg Bornemann <joerg.bornemann@qt.io>2021-07-06 18:24:11 +0200
committerJoerg Bornemann <joerg.bornemann@qt.io>2021-07-06 21:05:56 +0200
commit366368d881b147c20b9e614f00614a07cf46f445 (patch)
tree090aea8a2c9ad5f094475e8431bf995ab8b19c91
parentc4c0c95dd9cb7ff1c803f88ee8a89da4cf9c7dd3 (diff)
downloadqtwebchannel-366368d881b147c20b9e614f00614a07cf46f445.tar.gz
CMake: Don't give plugins PUBLIC usage requirements
The pro2cmake.py conversion script faithfully reproduced the .pro files for the plugins, which specified the libraries as public. But in CMake, the implications of this are that public usage requirements should then be propagated to consumers. We don't expect any consumers, since a plugin is created as a MODULE library in CMake, so for Windows we don't even have an import library to link with. The only exception to this is for static builds where plugins are created as STATIC libraries instead, but only in certain controlled situations do we then link to plugins. Even then, usage requirements are not expected to propagate to the consumers, so these relationships should always be specified as private. Pick-to: 6.2 Task-number: QTBUG-90819 Change-Id: Ia7a8f27d4eecf067055511577ec664ad857905cd Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
-rw-r--r--src/imports/webchannel/CMakeLists.txt2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/imports/webchannel/CMakeLists.txt b/src/imports/webchannel/CMakeLists.txt
index 1d6f6e9..da49839 100644
--- a/src/imports/webchannel/CMakeLists.txt
+++ b/src/imports/webchannel/CMakeLists.txt
@@ -18,7 +18,7 @@ qt_internal_add_qml_module(webchannel
plugin.cpp
INCLUDE_DIRECTORIES
../../webchannel
- PUBLIC_LIBRARIES
+ LIBRARIES
Qt::Core
Qt::Quick
Qt::WebChannelPrivate