<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/zookeeper.git/zookeeper-client, branch master</title>
<subtitle>git.apache.org: repos/asf/zookeeper.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/'/>
<entry>
<title>[ZOOKEEPER-4674] TestReadOnlyClient.cc: Stop/start "normal" server in test setUp/tearDown (#1983)</title>
<updated>2023-02-13T15:26:27+00:00</updated>
<author>
<name>Enrico Olivelli</name>
<email>eolivelli@apache.org</email>
</author>
<published>2023-02-13T15:26:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=2d1bac7e077f49a7149d3fb878a2c73b9e627f6e'/>
<id>2d1bac7e077f49a7149d3fb878a2c73b9e627f6e</id>
<content type='text'>
Co-authored-by: Damien Diederen &lt;dd@crosstwine.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Co-authored-by: Damien Diederen &lt;dd@crosstwine.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4654: Fix C client test compilation error in Util.cc.</title>
<updated>2022-12-18T17:37:53+00:00</updated>
<author>
<name>Chris Nauroth</name>
<email>cnauroth@apache.org</email>
</author>
<published>2022-12-18T17:37:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=9a43bc95aa8c95808d585b7aafb375a1e438a581'/>
<id>9a43bc95aa8c95808d585b7aafb375a1e438a581</id>
<content type='text'>
Author: Chris Nauroth &lt;cnauroth@apache.org&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;, Mate Szalay-Beko &lt;symat@apache.org&gt;

Closes #1967 from cnauroth/ZOOKEEPER-4654
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Author: Chris Nauroth &lt;cnauroth@apache.org&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;, Mate Szalay-Beko &lt;symat@apache.org&gt;

Closes #1967 from cnauroth/ZOOKEEPER-4654
</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4641: GH CI fails with error: implicit declaration of function FIPS_mode</title>
<updated>2022-12-15T12:15:52+00:00</updated>
<author>
<name>Enrico Olivelli</name>
<email>eolivelli@apache.org</email>
</author>
<published>2022-12-15T12:15:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=50d5722dd3342530eae4a737d9759ec5f774c84b'/>
<id>50d5722dd3342530eae4a737d9759ec5f774c84b</id>
<content type='text'>
Modifications:
- remove the block, as it is used only for debug

More details here:
https://issues.apache.org/jira/browse/ZOOKEEPER-4641

Author: Enrico Olivelli &lt;enrico.olivelli@datastax.com&gt;

Reviewers: Andor Molnar &lt;andor@apache.org&gt;, Chris Nauroth &lt;cnauroth@apache.org&gt;, Mate Szalay-Beko &lt;symat@apache.org&gt;

Closes #1951 from eolivelli/fix/ZOOKEEPER-4641
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Modifications:
- remove the block, as it is used only for debug

More details here:
https://issues.apache.org/jira/browse/ZOOKEEPER-4641

Author: Enrico Olivelli &lt;enrico.olivelli@datastax.com&gt;

Reviewers: Andor Molnar &lt;andor@apache.org&gt;, Chris Nauroth &lt;cnauroth@apache.org&gt;, Mate Szalay-Beko &lt;symat@apache.org&gt;

Closes #1951 from eolivelli/fix/ZOOKEEPER-4641
</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4479: C tests: Avoid some jitter which results in flaky tests</title>
<updated>2022-03-01T16:13:50+00:00</updated>
<author>
<name>Damien Diederen</name>
<email>ddiederen@apache.org</email>
</author>
<published>2022-03-01T16:13:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=640b6dd65fd302ada1ac46c9b8c32f17dadb0d32'/>
<id>640b6dd65fd302ada1ac46c9b8c32f17dadb0d32</id>
<content type='text'>
With these commits, the various tests in `TestOperations.cc` set the `last_sent` and `last_recv` fields of the "force-connected" ZooKeeper handle to deterministic values (which match the initial value of the time mock).

When that value is not specified, these fields get set to the "real" time at the end of the  `forceConnected` function, which can be sufficiently different from the value held in the mock for some of the tests to fail.

Author: Damien Diederen &lt;ddiederen@apache.org&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;

Closes #1827 from ztzg/ZOOKEEPER-4479-flaky-c-test-operations
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With these commits, the various tests in `TestOperations.cc` set the `last_sent` and `last_recv` fields of the "force-connected" ZooKeeper handle to deterministic values (which match the initial value of the time mock).

When that value is not specified, these fields get set to the "real" time at the end of the  `forceConnected` function, which can be sufficiently different from the value held in the mock for some of the tests to fail.

Author: Damien Diederen &lt;ddiederen@apache.org&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;

Closes #1827 from ztzg/ZOOKEEPER-4479-flaky-c-test-operations
</pre>
</div>
</content>
</entry>
<entry>
<title>[maven-release-plugin] prepare for next development iteration</title>
<updated>2022-02-03T07:55:04+00:00</updated>
<author>
<name>Enrico Olivelli</name>
<email>eolivelli@gmail.com</email>
</author>
<published>2022-02-03T07:55:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=a88eed897187e2b5e008fca766fdebb216289917'/>
<id>a88eed897187e2b5e008fca766fdebb216289917</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4461: Use logback in zookeeper-contrib project</title>
<updated>2022-02-01T10:39:04+00:00</updated>
<author>
<name>Andor Molnar</name>
<email>andor@apache.org</email>
</author>
<published>2022-02-01T10:39:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=04c7ad115e298387e4a75dfe14013f6c6aa68a6d'/>
<id>04c7ad115e298387e4a75dfe14013f6c6aa68a6d</id>
<content type='text'>
I've only found Ant references in the `-recipes` projects which I don't necesseraly want to migrate, so this patch is focusing on `-contrib` projects.

Please review.

Author: Andor Molnar &lt;andor@apache.org&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;

Closes #1807 from anmolnar/ZOOKEEPER-4461
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I've only found Ant references in the `-recipes` projects which I don't necesseraly want to migrate, so this patch is focusing on `-contrib` projects.

Please review.

Author: Andor Molnar &lt;andor@apache.org&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;

Closes #1807 from anmolnar/ZOOKEEPER-4461
</pre>
</div>
</content>
</entry>
<entry>
<title>fix a typo in zookeeper.h</title>
<updated>2021-11-21T04:39:22+00:00</updated>
<author>
<name>fengpan0403</name>
<email>fengpan0403@163.com</email>
</author>
<published>2021-11-21T04:39:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=f4f0bed00dd254e34aedfe408799f557d60fd0e7'/>
<id>f4f0bed00dd254e34aedfe408799f557d60fd0e7</id>
<content type='text'>
Typo fix

Author: fengpan0403 &lt;fengpan0403@163.com&gt;

Reviewers: maoling &lt;maoling@apache.org&gt;

Closes #1778 from fengpan0403/master
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Typo fix

Author: fengpan0403 &lt;fengpan0403@163.com&gt;

Reviewers: maoling &lt;maoling@apache.org&gt;

Closes #1778 from fengpan0403/master
</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation</title>
<updated>2021-08-25T12:14:22+00:00</updated>
<author>
<name>Damien Diederen</name>
<email>ddiederen@apache.org</email>
</author>
<published>2021-08-25T12:14:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=06467dc8c20e6c7357c19904f6214bb406262ba2'/>
<id>06467dc8c20e6c7357c19904f6214bb406262ba2</id>
<content type='text'>
Before this, the client was ignoring the error field of the response header, and only considering SASL-level errors.

This commit makes it consider `hdr.err`.  It also zeroes the `res` data structure, to avoid a crash in `deallocate` if `deserialize` is skipped, and sets `input_buffer` to `NULL` to avoid a double-free.

(I looked into adding a non-regression test, but doing so requires adding quite a bit of infrastructure to the mocks so that the SASL library can be correctly initialized.  Punting for now.)

Author: Damien Diederen &lt;ddiederen@apache.org&gt;

Reviewers: Enrico Olivelli&lt;eolivelli@apache.org&gt;

Closes #1733 from ztzg/ZOOKEEPER-4342-robustify-c-client-sasl-errors
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before this, the client was ignoring the error field of the response header, and only considering SASL-level errors.

This commit makes it consider `hdr.err`.  It also zeroes the `res` data structure, to avoid a crash in `deallocate` if `deserialize` is skipped, and sets `input_buffer` to `NULL` to avoid a double-free.

(I looked into adding a non-regression test, but doing so requires adding quite a bit of infrastructure to the mocks so that the SASL library can be correctly initialized.  Punting for now.)

Author: Damien Diederen &lt;ddiederen@apache.org&gt;

Reviewers: Enrico Olivelli&lt;eolivelli@apache.org&gt;

Closes #1733 from ztzg/ZOOKEEPER-4342-robustify-c-client-sasl-errors
</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4210: Preserve return code from nonblocking send</title>
<updated>2021-03-09T20:29:08+00:00</updated>
<author>
<name>Sam Mikes</name>
<email>smikes@apple.com</email>
</author>
<published>2021-03-09T20:29:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=1944f77aab458c79de0aee91c766b3c04c0d6417'/>
<id>1944f77aab458c79de0aee91c766b3c04c0d6417</id>
<content type='text'>
Async API calls attempt to flush the send buffer, which
calls flush_send_queue(); and can report
  ZOPERATIONTIMEOUT
  ZSYSTEMERROR
  ZCONNECTIONLOSS

Specifically: send_buffer() calls send(2) with MSG_NOSIGNAL,
which can return EPIPE; then send_buffer return -1, causing
ZCONNECTIONLOSS from flush_send_queue().

Current async API calls drop the return value from flush_send_queue(),
as below:

    adaptor_send_queue(zh, 0);
    return (rc &lt; 0)?ZMARSHALLINGERROR:ZOK;

The async API then returns ZOK instead of ZCONNECTIONLOSS.

Author: Sam Mikes &lt;smikes@apple.com&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;, Damien Diederen &lt;ddiederen@apache.org&gt;

Closes #1602 from smikes/asyncsend-returncode-3.6
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Async API calls attempt to flush the send buffer, which
calls flush_send_queue(); and can report
  ZOPERATIONTIMEOUT
  ZSYSTEMERROR
  ZCONNECTIONLOSS

Specifically: send_buffer() calls send(2) with MSG_NOSIGNAL,
which can return EPIPE; then send_buffer return -1, causing
ZCONNECTIONLOSS from flush_send_queue().

Current async API calls drop the return value from flush_send_queue(),
as below:

    adaptor_send_queue(zh, 0);
    return (rc &lt; 0)?ZMARSHALLINGERROR:ZOK;

The async API then returns ZOK instead of ZCONNECTIONLOSS.

Author: Sam Mikes &lt;smikes@apple.com&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;, Damien Diederen &lt;ddiederen@apache.org&gt;

Closes #1602 from smikes/asyncsend-returncode-3.6
</pre>
</div>
</content>
</entry>
<entry>
<title>ZOOKEEPER-4217: add new arg 'func' to handle_socket_error_msg()</title>
<updated>2021-03-07T09:49:58+00:00</updated>
<author>
<name>Sam Mikes</name>
<email>smikes@apple.com</email>
</author>
<published>2021-03-07T09:49:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/zookeeper.git/commit/?id=eafb93ac3edd28ff23b5b08b05e6ead7e44d85c6'/>
<id>eafb93ac3edd28ff23b5b08b05e6ead7e44d85c6</id>
<content type='text'>
Add argument `const char *func` typically initialized with __func__ to include current function name in log message.

Author: Sam Mikes &lt;smikes@apple.com&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;, Mate Szalay-Beko &lt;symat@apache.org&gt;, Damien Diederen &lt;ddiederen@apache.org&gt;

Closes #1609 from smikes/handle-msg-report-func
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add argument `const char *func` typically initialized with __func__ to include current function name in log message.

Author: Sam Mikes &lt;smikes@apple.com&gt;

Reviewers: Enrico Olivelli &lt;eolivelli@apache.org&gt;, Mate Szalay-Beko &lt;symat@apache.org&gt;, Damien Diederen &lt;ddiederen@apache.org&gt;

Closes #1609 from smikes/handle-msg-report-func
</pre>
</div>
</content>
</entry>
</feed>
