From 65753f2d0307d51b2d15e66e76ef6599fac17264 Mon Sep 17 00:00:00 2001 From: "Brian J. Tarricone" Date: Wed, 26 Aug 2009 14:46:13 -0700 Subject: print warning if attempting to compare git revision versions we can't tell version ordering, but it's possible it's fine, so just print a warning and proceed. autogen.sh writers shouldn't depend on particular git revisions, only on release versions, but let's soft-allow it. --- scripts/xdt-autogen.in.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'scripts') diff --git a/scripts/xdt-autogen.in.in b/scripts/xdt-autogen.in.in index 6856b04..f8932fe 100644 --- a/scripts/xdt-autogen.in.in +++ b/scripts/xdt-autogen.in.in @@ -186,9 +186,10 @@ do_version_check() { XDT_AUTOGEN_VERSION_REV_NUM=`echo "$XDT_AUTOGEN_VERSION_REVISION" | sed -e 's/svn-r\([[:digit:]]\+\)/\1/'` test $rev_num -le $XDT_AUTOGEN_VERSION_REV_NUM || return 1 elif echo "$revision" | grep -q "git"; then - echo "Error: git revision comparison not yet implemented. Please file a bug:" - echo "@PACKAGE_BUGREPORT@" - exit 1 + # since git rev info is of the form "git-$SHORT_SHA1", they cannot + # be ordered without knowing the full git history. + echo "xdt-autogen: Git revision comparison is not reliable. Continuing anyway." >&2 + echo " If you experience problems, upgrade xfce4-dev-tools." >&2 fi fi -- cgit v1.2.1