From 70d87690a39222277c2beab0649e343a78dee908 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Sat, 7 May 2022 10:03:27 +0100 Subject: patch 8.2.4898: Coverity complains about pointer usage Problem: Coverity complains about pointer usage. Solution: Move code for increment/decerment. --- src/vim9compile.c | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) (limited to 'src/vim9compile.c') diff --git a/src/vim9compile.c b/src/vim9compile.c index 9b7108b83..15dab9862 100644 --- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -2018,20 +2018,6 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx) lhs.lhs_name = NULL; - sp = p; - p = skipwhite(p); - op = p; - oplen = assignment_len(p, &heredoc); - - if (var_count > 0 && oplen == 0) - // can be something like "[1, 2]->func()" - return arg; - - if (oplen > 0 && (!VIM_ISWHITE(*sp) || !IS_WHITE_OR_NUL(op[oplen]))) - { - error_white_both(op, oplen); - return NULL; - } if (eap->cmdidx == CMD_increment || eap->cmdidx == CMD_decrement) { if (VIM_ISWHITE(eap->cmd[2])) @@ -2044,6 +2030,23 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx) oplen = 2; incdec = TRUE; } + else + { + sp = p; + p = skipwhite(p); + op = p; + oplen = assignment_len(p, &heredoc); + + if (var_count > 0 && oplen == 0) + // can be something like "[1, 2]->func()" + return arg; + + if (oplen > 0 && (!VIM_ISWHITE(*sp) || !IS_WHITE_OR_NUL(op[oplen]))) + { + error_white_both(op, oplen); + return NULL; + } + } if (heredoc) { -- cgit v1.2.1