From 8d4ed11da635a1abe0ef2d795b4d48824c54d0e7 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Sat, 4 Apr 2020 14:50:32 +0200 Subject: patch 8.2.0510: Coverity complains about using uninitialized variable Problem: Coverity complains about using uninitialized variable. Solution: Assign a value to "scol". Move code inside NULL check. --- src/popupwin.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'src/popupwin.c') diff --git a/src/popupwin.c b/src/popupwin.c index 3a0dcb96a..608db4c09 100644 --- a/src/popupwin.c +++ b/src/popupwin.c @@ -798,16 +798,16 @@ apply_general_options(win_T *wp, dict_T *dict) if (*str != NUL) wp->w_border_char[i] = mb_ptr2char(str); } - } - if (list->lv_len == 1) - for (i = 1; i < 8; ++i) - wp->w_border_char[i] = wp->w_border_char[0]; - if (list->lv_len == 2) - { - for (i = 4; i < 8; ++i) - wp->w_border_char[i] = wp->w_border_char[1]; - for (i = 1; i < 4; ++i) - wp->w_border_char[i] = wp->w_border_char[0]; + if (list->lv_len == 1) + for (i = 1; i < 8; ++i) + wp->w_border_char[i] = wp->w_border_char[0]; + if (list->lv_len == 2) + { + for (i = 4; i < 8; ++i) + wp->w_border_char[i] = wp->w_border_char[1]; + for (i = 1; i < 4; ++i) + wp->w_border_char[i] = wp->w_border_char[0]; + } } } } -- cgit v1.2.1