From 0c34d562647f029faca40f7733ccfb7b5377672b Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Fri, 18 Nov 2022 14:07:20 +0000 Subject: patch 9.0.0901: setting w_leftcol and handling side effects is confusing Problem: Setting w_leftcol and handling side effects is confusing. Solution: Use a function to set w_leftcol() and handle side effects. --- src/mouse.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/mouse.c') diff --git a/src/mouse.c b/src/mouse.c index 5ebf125dc..8348ba195 100644 --- a/src/mouse.c +++ b/src/mouse.c @@ -2035,8 +2035,6 @@ do_mousescroll_horiz(long_u leftcol) if (curwin->w_leftcol == (colnr_T)leftcol) return FALSE; // already there - curwin->w_leftcol = (colnr_T)leftcol; - // When the line of the cursor is too short, move the cursor to the // longest visible line. if ( @@ -2050,7 +2048,7 @@ do_mousescroll_horiz(long_u leftcol) curwin->w_cursor.col = 0; } - return leftcol_changed(); + return set_leftcol((colnr_T)leftcol); } /* @@ -2098,7 +2096,7 @@ do_mousescroll(int mode, cmdarg_T *cap) send_keys_to_term(curbuf->b_term, cap->cmdchar, mod_mask, FALSE); else # endif - // For insert mode, don't scroll the window in which completion is being + // For Insert mode, don't scroll the window in which completion is being // done. if (mode == MODE_NORMAL || !pum_visible() || curwin != old_curwin) { -- cgit v1.2.1