From c04f62346bfd6b92151908239a3c5ab1a7d18f2a Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Sun, 19 Sep 2021 17:01:39 +0200 Subject: patch 8.2.3449: sort fails if the sort compare function returns 999 Problem: Sort fails if the sort compare function returns 999. Solution: Adjust value to -1 / 0 / 1. (Yasuhiro Matsumoto, closes #8884) --- src/list.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/list.c') diff --git a/src/list.c b/src/list.c index 8e67a61db..16e59837e 100644 --- a/src/list.c +++ b/src/list.c @@ -1945,7 +1945,13 @@ item_compare2(const void *s1, const void *s2) if (res == FAIL) res = ITEM_COMPARE_FAIL; else + { res = (int)tv_get_number_chk(&rettv, &sortinfo->item_compare_func_err); + if (res > 0) + res = 1; + else if (res < 0) + res = -1; + } if (sortinfo->item_compare_func_err) res = ITEM_COMPARE_FAIL; // return value has wrong type clear_tv(&rettv); -- cgit v1.2.1