From 1b6acf02b7e685ecb87ccba52c91835a7519073e Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Thu, 5 Aug 2021 16:47:08 +0200 Subject: patch 8.2.3294: Lua: memory leak when adding dict item fails Problem: Lua: memory leak when adding dict item fails. Solution: Free the typval and the dict item. --- src/if_lua.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'src/if_lua.c') diff --git a/src/if_lua.c b/src/if_lua.c index 144fcbea5..6ac395112 100644 --- a/src/if_lua.c +++ b/src/if_lua.c @@ -1859,12 +1859,20 @@ luaV_setvar(lua_State *L) // Need to create an entry di = dictitem_alloc((char_u *)name); if (di == NULL) + { + clear_tv(&tv); return 0; + } // Update the value copy_tv(&tv, &di->di_tv); if (dict_add(dict, di) == FAIL) + { + dictitem_free(di); + clear_tv(&tv); return luaL_error(L, "Couldn't add to dictionary"); - } else + } + } + else { // Clear the old value clear_tv(&di->di_tv); -- cgit v1.2.1