From 9954dc39ea090cee6bf41c888c41e60d9f52c3b8 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Fri, 11 Nov 2022 22:58:36 +0000 Subject: patch 9.0.0861: solution for "!!sort" in closed fold is not optimal Problem: Solution for "!!sort" in closed fold is not optimal. Solution: Use a different range instead of the subtle difference in handling a range with an offset. (issue #11487) --- src/ex_docmd.c | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) (limited to 'src/ex_docmd.c') diff --git a/src/ex_docmd.c b/src/ex_docmd.c index 02bca38e0..d5037a456 100644 --- a/src/ex_docmd.c +++ b/src/ex_docmd.c @@ -4308,9 +4308,6 @@ get_address( lnum = MAXLNUM; do { -#ifdef FEAT_FOLDING - int base_char = *cmd; -#endif switch (*cmd) { case '.': // '.' - Cursor position @@ -4631,16 +4628,10 @@ get_address( else { #ifdef FEAT_FOLDING - // Relative line addressing: need to adjust for closed folds - // after the first address. - // Subtle difference: "number,+number" and "number,-number" - // adjusts to end of closed fold before adding/subtracting, - // while "number,.+number" adjusts to end of closed fold after - // adding to make "!!" expanded into ".,.+N" work correctly. - int adjust_for_folding = addr_type == ADDR_LINES - && (i == '-' || i == '+') - && address_count >= 2; - if (adjust_for_folding && (i == '-' || base_char != '.')) + // Relative line addressing: need to adjust for lines in a + // closed fold after the first address. + if (addr_type == ADDR_LINES && (i == '-' || i == '+') + && address_count >= 2) (void)hasFolding(lnum, NULL, &lnum); #endif if (i == '-') @@ -4653,12 +4644,6 @@ get_address( goto error; } lnum += n; -#ifdef FEAT_FOLDING - // ".+number" rounds up to the end of a closed fold after - // adding, so that ":!!sort" sorts one closed fold. - if (adjust_for_folding && base_char == '.') - (void)hasFolding(lnum, NULL, &lnum); -#endif } } } -- cgit v1.2.1