From 8903676d3d4c3fcb37d2a55c67370f30806b1626 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Tue, 12 Jun 2018 14:58:39 +0200 Subject: patch 8.1.0044: if a test function exists Vim this may go unnoticed Problem: If a test function exists Vim this may go unnoticed. Solution: Check for a test funtion quitting Vim. Fix tests that did exit Vim. --- src/testdir/runtest.vim | 12 ++++++++++++ src/testdir/test_assert.vim | 6 ++++++ src/version.c | 2 ++ 3 files changed, 20 insertions(+) diff --git a/src/testdir/runtest.vim b/src/testdir/runtest.vim index 5b8126d5d..4f508a487 100644 --- a/src/testdir/runtest.vim +++ b/src/testdir/runtest.vim @@ -124,7 +124,10 @@ func RunTheTest(test) exe 'call ' . a:test else try + let s:test = a:test + au VimLeavePre * call EarlyExit(s:test) exe 'call ' . a:test + au! VimLeavePre catch /^\cskipped/ call add(s:messages, ' Skipped') call add(s:skipped, 'SKIPPED ' . a:test . ': ' . substitute(v:exception, '^\S*\s\+', '', '')) @@ -174,6 +177,15 @@ func AfterTheTest() endif endfunc +func EarlyExit(test) + " It's OK for the test we use to test the quit detection. + if a:test != 'Test_zz_quit_detected()' + call add(v:errors, 'Test caused Vim to exit: ' . a:test) + endif + + call FinishTesting() +endfunc + " This function can be called by a test if it wants to abort testing. func FinishTesting() call AfterTheTest() diff --git a/src/testdir/test_assert.vim b/src/testdir/test_assert.vim index 61147286f..28db289b2 100644 --- a/src/testdir/test_assert.vim +++ b/src/testdir/test_assert.vim @@ -198,3 +198,9 @@ func Test_user_is_happy() smile sleep 300m endfunc + +" Must be last. +func Test_zz_quit_detected() + " Verify that if a test function ends Vim the test script detects this. + quit +endfunc diff --git a/src/version.c b/src/version.c index 100506b0b..dfdc07d59 100644 --- a/src/version.c +++ b/src/version.c @@ -761,6 +761,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 44, /**/ 43, /**/ -- cgit v1.2.1