From f85063c3267505a4716229d3b10650421e131ded Mon Sep 17 00:00:00 2001 From: Niels De Graef Date: Sat, 18 Feb 2023 21:32:52 +0100 Subject: gtkmodule: Improve error messages Be a bit more specific about some of the errors that valac can encounter when parsing a UI file. (for my use case specifically, it helped me to figure out I had a tag without a name attribute in one of my UI files) --- codegen/valagtkmodule.vala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codegen/valagtkmodule.vala b/codegen/valagtkmodule.vala index e129fcba0..69125ce57 100644 --- a/codegen/valagtkmodule.vala +++ b/codegen/valagtkmodule.vala @@ -294,7 +294,7 @@ public class Vala.GtkModule : GSignalModule { } else if (current_object != null && current_token == MarkupTokenType.START_ELEMENT && (current_name == "property" || current_name == "binding")) { var property_name = reader.get_attribute ("name"); if (property_name == null) { - Report.error (node.source_reference, "Invalid binding in ui file `%s'", ui_file); + Report.error (node.source_reference, "Invalid %s without name in ui file `%s'", current_name, ui_file); current_token = reader.read_token (null, null); continue; } @@ -318,7 +318,7 @@ public class Vala.GtkModule : GSignalModule { if (current_property != null) { if (handler_name == null) { - Report.error (node.source_reference, "Invalid closure in ui file `%s'", ui_file); + Report.error (node.source_reference, "Invalid %s without function in ui file `%s'", current_name, ui_file); current_token = reader.read_token (null, null); continue; } -- cgit v1.2.1