<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/util-linux.git/libmount/src/tab_update.c, branch baserock/morph</title>
<subtitle>git.kernel.org: pub/scm/utils/util-linux/util-linux.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/'/>
<entry>
<title>libmount: make mnt_table_replace_file() more robust [coverity scan]</title>
<updated>2013-10-01T14:56:26+00:00</updated>
<author>
<name>Karel Zak</name>
<email>kzak@redhat.com</email>
</author>
<published>2013-10-01T14:56:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=a84ec176eca207eadcd2a47056ad44df082f1b02'/>
<id>a84ec176eca207eadcd2a47056ad44df082f1b02</id>
<content type='text'>
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: add reference counter to libmnt_table</title>
<updated>2013-08-21T14:07:25+00:00</updated>
<author>
<name>Karel Zak</name>
<email>kzak@redhat.com</email>
</author>
<published>2013-08-21T14:07:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=c9f1585e67717068e82ba22bc498aabf2954c113'/>
<id>c9f1585e67717068e82ba22bc498aabf2954c113</id>
<content type='text'>
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: add reference counting to libmount_fs</title>
<updated>2013-08-21T10:48:42+00:00</updated>
<author>
<name>Karel Zak</name>
<email>kzak@redhat.com</email>
</author>
<published>2013-08-21T10:31:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=26d0c0aefde9a94f29d9850514fcbcf638eb8728'/>
<id>26d0c0aefde9a94f29d9850514fcbcf638eb8728</id>
<content type='text'>
 * mnt_new_fs() returns object with refcount=1
 * mnt_free_fs() does not care about reference counter

 * new functions mnt_ref_fs() and mnt_unref_fs()

 * mnt_table_add_fs() and mnt_table_rem_fs() uses reference counter

 * libmmnt_context uses reference counter for internal FS (as it could be
   shared outside the context)

 * backwardly incompatible change:

	- FS could be deallocated after mnt_table_remove_fs()

 * it's recommended to use mnt_unref_fs() after mnt_table_add_fs()

Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 * mnt_new_fs() returns object with refcount=1
 * mnt_free_fs() does not care about reference counter

 * new functions mnt_ref_fs() and mnt_unref_fs()

 * mnt_table_add_fs() and mnt_table_rem_fs() uses reference counter

 * libmmnt_context uses reference counter for internal FS (as it could be
   shared outside the context)

 * backwardly incompatible change:

	- FS could be deallocated after mnt_table_remove_fs()

 * it's recommended to use mnt_unref_fs() after mnt_table_add_fs()

Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: fix typos</title>
<updated>2013-08-05T08:47:02+00:00</updated>
<author>
<name>Ondrej Oprala</name>
<email>ooprala@redhat.com</email>
</author>
<published>2013-08-02T10:23:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=d58b315704bf21c3552d1b9b0743cfd6585ef972'/>
<id>d58b315704bf21c3552d1b9b0743cfd6585ef972</id>
<content type='text'>
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: change tailing to trailing in *_tailing_comments functions</title>
<updated>2013-08-01T09:21:47+00:00</updated>
<author>
<name>Ondrej Oprala</name>
<email>ooprala@redhat.com</email>
</author>
<published>2013-07-30T12:17:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=3035ba93af698f28c91acc85ffbfeeeb74b8f8da'/>
<id>3035ba93af698f28c91acc85ffbfeeeb74b8f8da</id>
<content type='text'>
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: add functions to safely replace a fs table</title>
<updated>2013-07-03T09:21:33+00:00</updated>
<author>
<name>Ondrej Oprala</name>
<email>ooprala@redhat.com</email>
</author>
<published>2013-06-14T11:00:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=d22f2822ed873bac1dbb28aa5fd5351f3a27b2b8'/>
<id>d22f2822ed873bac1dbb28aa5fd5351f3a27b2b8</id>
<content type='text'>
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: add functions to handle comments in fs tables</title>
<updated>2013-07-03T08:17:37+00:00</updated>
<author>
<name>Ondrej Oprala</name>
<email>ooprala@redhat.com</email>
</author>
<published>2013-06-14T10:41:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=cb90e24e804e2f95eadf01e96561749092c858c1'/>
<id>cb90e24e804e2f95eadf01e96561749092c858c1</id>
<content type='text'>
Co-Author: Karel Zak &lt;kzak@redhat.com&gt;
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Co-Author: Karel Zak &lt;kzak@redhat.com&gt;
Signed-off-by: Ondrej Oprala &lt;ooprala@redhat.com&gt;
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: fix mount.nfs segfault, rely on assert() rather than on nonnull</title>
<updated>2013-04-12T10:35:34+00:00</updated>
<author>
<name>Karel Zak</name>
<email>kzak@redhat.com</email>
</author>
<published>2013-04-12T10:35:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=4569bbeab783632c81ee14793da84b3e29444543'/>
<id>4569bbeab783632c81ee14793da84b3e29444543</id>
<content type='text'>
We use
   mnt_optstr_append_option(&amp;o, mnt_fs_get_vfs_options(fs), NULL);

in mount.nfs, unfortunately mnt_optstr_append_option() has been marked
ass nonnull(1, 2). That's wrong because append and prepend should
robust enough to accept NULL as option name.

The patch also removes almost all __attribute__((nonnull). It seems
better to rely on assert() to have usable feedback. In many cases
(nonnull) is premature optimization for the library. This attribute
makes sense for things like strlen() or so...

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=948274
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We use
   mnt_optstr_append_option(&amp;o, mnt_fs_get_vfs_options(fs), NULL);

in mount.nfs, unfortunately mnt_optstr_append_option() has been marked
ass nonnull(1, 2). That's wrong because append and prepend should
robust enough to accept NULL as option name.

The patch also removes almost all __attribute__((nonnull). It seems
better to rely on assert() to have usable feedback. In many cases
(nonnull) is premature optimization for the library. This attribute
makes sense for things like strlen() or so...

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=948274
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: use O_CLOEXEC</title>
<updated>2013-04-03T14:14:03+00:00</updated>
<author>
<name>Karel Zak</name>
<email>kzak@redhat.com</email>
</author>
<published>2013-04-03T14:14:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=1eb8539d3b1d2cb636bb73222daeb0bf4f68d7ae'/>
<id>1eb8539d3b1d2cb636bb73222daeb0bf4f68d7ae</id>
<content type='text'>
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libmount: clean nonnull attribute usage</title>
<updated>2012-12-04T13:22:39+00:00</updated>
<author>
<name>Karel Zak</name>
<email>kzak@redhat.com</email>
</author>
<published>2012-12-04T13:22:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/util-linux.git/commit/?id=ba2bdf41c436640286df40529cddede46b3ba5d8'/>
<id>ba2bdf41c436640286df40529cddede46b3ba5d8</id>
<content type='text'>
 - use __attribute__((nonnull) for functions where we not able to
   return an return code ("is", "has" and some "get" functions).

 - use __attribute__((nonnull) for small functions where we
   always modify any of the function argument (some mnt_optstr_* functions)

Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 - use __attribute__((nonnull) for functions where we not able to
   return an return code ("is", "has" and some "get" functions).

 - use __attribute__((nonnull) for small functions where we
   always modify any of the function argument (some mnt_optstr_* functions)

Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
