From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- common/bootm_os.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'common/bootm_os.c') diff --git a/common/bootm_os.c b/common/bootm_os.c index a3c360e80a..6a95e0de33 100644 --- a/common/bootm_os.c +++ b/common/bootm_os.c @@ -61,7 +61,7 @@ static void copy_args(char *dest, int argc, char *const argv[], char delim) static int do_bootm_netbsd(int flag, int argc, char *const argv[], bootm_headers_t *images) { - void (*loader)(bd_t *, image_header_t *, char *, char *); + void (*loader)(struct bd_info *, image_header_t *, char *, char *); image_header_t *os_hdr, *hdr; ulong kernel_data, kernel_len; char *cmdline; @@ -109,7 +109,7 @@ static int do_bootm_netbsd(int flag, int argc, char *const argv[], cmdline = ""; } - loader = (void (*)(bd_t *, image_header_t *, char *, char *))images->ep; + loader = (void (*)(struct bd_info *, image_header_t *, char *, char *))images->ep; printf("## Transferring control to NetBSD stage-2 loader (at address %08lx) ...\n", (ulong)loader); @@ -155,7 +155,7 @@ static int do_bootm_lynxkdi(int flag, int argc, char *const argv[], static int do_bootm_rtems(int flag, int argc, char *const argv[], bootm_headers_t *images) { - void (*entry_point)(bd_t *); + void (*entry_point)(struct bd_info *); if (flag != BOOTM_STATE_OS_GO) return 0; @@ -167,7 +167,7 @@ static int do_bootm_rtems(int flag, int argc, char *const argv[], } #endif - entry_point = (void (*)(bd_t *))images->ep; + entry_point = (void (*)(struct bd_info *))images->ep; printf("## Transferring control to RTEMS (at address %08lx) ...\n", (ulong)entry_point); -- cgit v1.2.1