From 3d5931e5986a49c44cdab845c6751d845812e8d8 Mon Sep 17 00:00:00 2001 From: Heiko Schocher Date: Fri, 18 Jan 2019 10:45:56 +0100 Subject: env: sf: fix environment in SPI NOR commit 9a9d66f5eff0 ("env: add spi_flash_read_env function") breaks Environment functionality, as it reads only until 2 \0 are found, but fills the buffer with 0x0 instead 0xff which leads in an incorrect crc sum. Fix: init the read buffer with 0xff instead 0x00 Signed-off-by: Heiko Schocher --- env/sf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/sf.c b/env/sf.c index b3dec82c35..31dd003575 100644 --- a/env/sf.c +++ b/env/sf.c @@ -98,7 +98,7 @@ static int spi_flash_read_env(struct spi_flash *flash, u32 offset, size_t len, u32 addr = 0; u32 page_size = flash->page_size; - memset(buf, 0x0, len); + memset(buf, 0xff, len); for (int i = 0; i < len / page_size; ++i) { int ret = spi_flash_read(flash, offset, page_size, &((char *)buf)[addr]); -- cgit v1.2.1