diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/freescale/mpc837xemds/mpc837xemds.c | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/freescale/mpc837xemds/mpc837xemds.c')
-rw-r--r-- | board/freescale/mpc837xemds/mpc837xemds.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/board/freescale/mpc837xemds/mpc837xemds.c b/board/freescale/mpc837xemds/mpc837xemds.c index 182391ca9c..f515299bc9 100644 --- a/board/freescale/mpc837xemds/mpc837xemds.c +++ b/board/freescale/mpc837xemds/mpc837xemds.c @@ -64,7 +64,7 @@ int board_early_init_f(void) } #ifdef CONFIG_FSL_ESDHC -int board_mmc_init(bd_t *bd) +int board_mmc_init(struct bd_info *bd) { struct immap __iomem *im = (struct immap __iomem *)CONFIG_SYS_IMMR; u8 *bcsr = (u8 *)CONFIG_SYS_BCSR; @@ -85,7 +85,7 @@ int board_mmc_init(bd_t *bd) #endif #if defined(CONFIG_TSEC1) || defined(CONFIG_TSEC2) -int board_eth_init(bd_t *bd) +int board_eth_init(struct bd_info *bd) { struct fsl_pq_mdio_info mdio_info; struct tsec_info_struct tsec_info[2]; @@ -141,7 +141,7 @@ int board_eth_init(bd_t *bd) return tsec_eth_init(bd, tsec_info, num); } -static void __ft_tsec_fixup(void *blob, bd_t *bd, const char *alias, +static void __ft_tsec_fixup(void *blob, struct bd_info *bd, const char *alias, int phy_addr) { const u32 *ph; @@ -186,7 +186,7 @@ static void __ft_tsec_fixup(void *blob, bd_t *bd, const char *alias, } } -static void ft_tsec_fixup(void *blob, bd_t *bd) +static void ft_tsec_fixup(void *blob, struct bd_info *bd) { struct immap __iomem *im = (struct immap __iomem *)CONFIG_SYS_IMMR; u32 rcwh = in_be32(&im->reset.rcwh); @@ -205,7 +205,7 @@ static void ft_tsec_fixup(void *blob, bd_t *bd) #endif } #else -static inline void ft_tsec_fixup(void *blob, bd_t *bd) {} +static inline void ft_tsec_fixup(void *blob, struct bd_info *bd) {} #endif /* defined(CONFIG_TSEC1) || defined(CONFIG_TSEC2) */ int board_early_init_r(void) @@ -312,7 +312,7 @@ int board_pci_host_broken(void) return 0; } -static void ft_pci_fixup(void *blob, bd_t *bd) +static void ft_pci_fixup(void *blob, struct bd_info *bd) { const char *status = "broken (no arbiter)"; int off; @@ -335,7 +335,7 @@ static void ft_pci_fixup(void *blob, bd_t *bd) #endif #if defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { ft_cpu_setup(blob, bd); ft_tsec_fixup(blob, bd); |