From c941f6b896cb417f8b1464093fa4abd6ec414138 Mon Sep 17 00:00:00 2001
From: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Date: Thu, 11 Feb 2010 16:20:06 +0000
Subject: Some more fixes about DBus extentions

---
 extensions/Logger.xml  | 36 +++++++++++++++++++++++++++---------
 extensions/Makefile.am |  3 ++-
 2 files changed, 29 insertions(+), 10 deletions(-)

(limited to 'extensions')

diff --git a/extensions/Logger.xml b/extensions/Logger.xml
index b63198b..5abe60f 100644
--- a/extensions/Logger.xml
+++ b/extensions/Logger.xml
@@ -22,7 +22,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
     <tp:added version="0.1">(as a draft)</tp:added>
 
     <tp:docstring>
-      <!-- FIXME -->
       An interface for requesting information from the Telepathy Logger
       service.
     </tp:docstring>
@@ -33,21 +32,24 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
           The identifier of the contact who originated this message.
         </tp:docstring>
       </tp:member>
+
       <tp:member type="s" name="Message">
         <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
         The body of the message sent to a 1-1 Chat or a Chat Room.
         </tp:docstring>
       </tp:member>
+
       <tp:member type="u" name="Timestamp">
         <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
         Unix timestamp for the log entry
         </tp:docstring>
       </tp:member>
+
       <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
-      <p>It represents a single message, received or sent.</p>
-      <p>The receiver is implicit in the request: if the sender is the user,
-      the receiver is the identifier in chat_id paramenter, if the sender is
-      not the user, the user is consequently the receiver of the message</p>
+        <p>It represents a single message, received or sent.</p>
+        <p>The receiver is implicit in the request: if the sender is the user,
+        the receiver is the identifier in chat_id paramenter, if the sender is
+        not the user, the user is consequently the receiver of the message</p>
       </tp:docstring>
     </tp:struct>
 
@@ -55,18 +57,34 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
             tp:name-for-bindings="Get_Recent_Messages">
       <arg direction="in" name="Account" type="o" tp:type="Account">
         <tp:docstring>
-          <!-- FIXME -->
+        The account path for the TpAccount to which the conversation is related
         </tp:docstring>
       </arg>
+
       <arg direction="in" name="Identifier" type="s">
         <tp:docstring>
-          <!-- FIXME -->
+        The buddy's identifier for the conversation
+        </tp:docstring>
+      </arg>
+
+      <arg direction="in" name="Is_Chatroom" type="b">
+        <tp:docstring>
+        Whether the conversation is a chatroom (i.e., XMMP's MUC) or not
         </tp:docstring>
       </arg>
-      <arg direction="in" name="Is_Chatroom" type="b" />
-      <arg direction="in" name="Lines" type="u" />
+
+      <arg direction="in" name="Lines" type="u">
+        <tp:docstring>
+        how many entries will be returned.
+
+        NOTE: to retreive information that would generate hight traffic, use
+        the library API approach instead of DBbus.
+        </tp:docstring>
+      </arg>
+
       <arg direction="out" name="Messages" type="a(ssu)"
            tp:type="Chat_Message[]" />
+
       <tp:docstring>
         Request the last Lines entries of logs for the specified couple
         Account+Identifier.
diff --git a/extensions/Makefile.am b/extensions/Makefile.am
index 5b2c871..79a3e27 100644
--- a/extensions/Makefile.am
+++ b/extensions/Makefile.am
@@ -29,7 +29,8 @@ BUILT_SOURCES = \
     _gen/all.xml \
     $(nodist_libtpl_extensions_la_SOURCES)
 
-CLEANFILES = $(BUILT_SOURCES)
+CLEANFILES = $(BUILT_SOURCES) \
+	_gen/
 
 AM_CFLAGS = $(ERROR_CFLAGS) @LIBTPL_CFLAGS@ @HANDLE_LEAK_DEBUG_CFLAGS@
 AM_LDFLAGS = @LIBTPL_LIBS@
-- 
cgit v1.2.1