diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-07-27 12:27:28 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-08-03 10:05:10 +0200 |
commit | 04499a70fbff3f6b798028473f5c9234a53eaa2d (patch) | |
tree | ec7a851e163ee20ba5211c16a86f1c251543e0a7 /src/run | |
parent | c7cfde640d2b32ff1eb893d1fcd291c25cd421e7 (diff) | |
download | systemd-04499a70fbff3f6b798028473f5c9234a53eaa2d.tar.gz |
Drop the text argument from assert_not_reached()
In general we almost never hit those asserts in production code, so users see
them very rarely, if ever. But either way, we just need something that users
can pass to the developers.
We have quite a few of those asserts, and some have fairly nice messages, but
many are like "WTF?" or "???" or "unexpected something". The error that is
printed includes the file location, and function name. In almost all functions
there's at most one assert, so the function name alone is enough to identify
the failure for a developer. So we don't get much extra from the message, and
we might just as well drop them.
Dropping them makes our code a tiny bit smaller, and most importantly, improves
development experience by making it easy to insert such an assert in the code
without thinking how to phrase the argument.
Diffstat (limited to 'src/run')
-rw-r--r-- | src/run/run.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/run/run.c b/src/run/run.c index 344c8f6641..0be974f03a 100644 --- a/src/run/run.c +++ b/src/run/run.c @@ -503,7 +503,7 @@ static int parse_argv(int argc, char *argv[]) { return -EINVAL; default: - assert_not_reached("Unhandled option"); + assert_not_reached(); } with_trigger = !!arg_path_property || !!arg_socket_property || arg_with_timer; @@ -1155,7 +1155,7 @@ static int start_transient_service( if (!pty_path) return log_oom(); } else - assert_not_reached("Can't allocate tty via ssh"); + assert_not_reached(); } /* Optionally, wait for the start job to complete. If we are supposed to read the service's stdin @@ -1628,7 +1628,7 @@ static int start_transient_trigger( else if (streq(suffix, ".timer")) r = transient_timer_set_properties(m); else - assert_not_reached("Invalid suffix"); + assert_not_reached(); if (r < 0) return r; |