A thinko in commit a1331f8d ("memscan: pass enum syslinux_memmap_types
around") causes many machines not to boot because the expression
"!SMT_FREE" always evaluates to "false", regardless of the value of
'type', which means that mem_init() may use reserved memory regions for
general allocation.

Signed-off-by: Matt Fleming <matt.fleming@intel.com>

Binary files exist in tests/ which can dramatically increase the size of
the release tarballs. Delete both regression and unit tests when
building any kind of a release.

Signed-off-by: Matt Fleming <matt.fleming@intel.com>

Improve our faith in the validity of the Syslinux code by writing unit
tests where possible. These should be used in addition to the regression
tests - unit tests are a means of doing very fine-grained testing of
code, whereas the regression tests are end-to-end tests that exercise
abstract functionality.

Unit tests run on your development machine and above all else, their
execution time should be kept to a minimum to encourage repeated runs of
the unit testsuite.

The Syslinux header hierarchy has been reconstructed under
tests/unittest/include. This allows us to reuse header files where
appropriate by simply creating a file with the same name and including
the original, e.g.

tests/unittest/include/com32.h:

  #include <../../../com32/include/com32.h>

Places where we need to override definitions (so that the tests build in
a dev environment) obviously won't include the original header file, but
such scenarios should be kept to a minimum, since you're not really
testing any Syslinux code that way.

To execute the collection of unit tests type,

  make unittest

Sample output might look like,

  Executing unit tests
      Running library unit tests...
        [+] zonelist passed
        [+] movebits passed
        [+] memscan passed

Signed-off-by: Matt Fleming <matt.fleming@intel.com>

A number of Syslinux releases have contained regressions when compared
with previous versions. Now that the size of the derivative grid has
exploded (PXELINUX, SYSLINUX,.... bios, efi32, efi64) we need to have
some means of ensuring we don't introduce regressions so easily.

Start building a suite of regression tests. Regression tests should test
end-to-end functionality, e.g. loading a Linux kernel. If a test fails,
that failure represents a regression in some behaviour, e.g. Syslinux
behaves differently than it previously did.

The idea is that when bugs are reported in Syslinux, we can create new
tests that reproduce the buggy behaviour. Once a fix has been committed
the new test should pass. From that point forward, the test provides a
means of ensuring we never reintroduce that bug.

The collection of tests illustrates the agreed upon behaviour of
Syslinux.

To execute the regression testsuite type,

  make regression

Sample output might look like,

  Executing regression tests for SYSLINUX
      Running Linux kernel regression tests...
        [+] empty passed
        [+] kernelhello passed
      Running COM32 module regression tests...
        [+] chaindisk passed
  Executing regression tests for PXELINUX
      Running Linux kernel regression tests...
        [!] empty failed
        [+] kernelhello passed
        [+] pxetest passed

Qemu is used to execute the regression tests in a virtual environment.
Because it takes time to load Qemu, we can forgive the regression
testsuite for not executing instantaneously. However, developers should
keep in mind the idea of "failing fast" in their regression tests to
minimize execution time - that is, if a test is going to fail, make it
fail as quickly as possible to reduce the testrun time.

It's possible to have derivative-specific tests, where the test only
runs for a specific Syslinux boot loader. For an example see pxetest in
tests/linux/Makefile.

Currently the regression testsuite requires root privileges to execute
and makes several calls to sudo(8). In future it would be nice to get
rid of this requirement.

Signed-off-by: Matt Fleming <matt.fleming@intel.com>

All the BIOS get_derivative_info() implementations are incorrect. They
all dereference pointers to various deriviative-specific data objects
instead of using the address of the objects.

This broke chain loading on SYSLINUX because the ->partoffset field
contained the dereferenced value of 'Hidden' rather than the address.

Signed-off-by: Matt Fleming <matt.fleming@intel.com>

This reverts commit 8dc346bfdc871329624378d4b48db94b40d0b2a4.

Users are reporting a regression caused by this commit, as unlikely as
it seems. Revert in the hope that things will begin working for them
again.

Signed-off-by: Matt Fleming <matt.fleming@intel.com>

Pull PXE legacynet DNS dotquad fix from Gene Cumm,

* 'pxe-dns-dotquad-for-mfleming' of git://github.com/geneC/syslinux:
  core/legacynet: Enable dot quad resolution

in dnsresolv.c:dns_resolv()

Signed-off-by: Gene Cumm <gene.cumm@gmail.com>

In theory we may have multiple subregions with SMT_FREE and
SMT_TERMINAL.  This can be fairly easily integrated into a small loop.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>

Allow syslinux_memmap_type() to report any combination of SMT_FREE and
SMT_TERMINAL as SMT_TERMINAL.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>