From 856c74e013eaa53902479b771e6c0cf1fea67745 Mon Sep 17 00:00:00 2001 From: Garming Sam Date: Fri, 14 Feb 2014 17:46:40 +1300 Subject: Remove NT_STATUS_IS_ERR_RETURN macro from the codebase. Following the current coding guidelines, it is considered bad practice to return from within a macro and change control flow as they look like normal function calls. Change-Id: I39b07b3a799331a5faa968629aa95b836cb78600 Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett Reviewed-by: Andreas Schneider --- source4/wrepl_server/wrepl_in_connection.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'source4/wrepl_server') diff --git a/source4/wrepl_server/wrepl_in_connection.c b/source4/wrepl_server/wrepl_in_connection.c index 251e5a02475..b8e9a16dc21 100644 --- a/source4/wrepl_server/wrepl_in_connection.c +++ b/source4/wrepl_server/wrepl_in_connection.c @@ -65,7 +65,9 @@ static NTSTATUS wreplsrv_process(struct wreplsrv_in_connection *wrepl_conn, } status = wreplsrv_in_call(call); - NT_STATUS_IS_ERR_RETURN(status); + if (NT_STATUS_IS_ERR(status)) { + return status; + } if (!NT_STATUS_IS_OK(status)) { /* w2k just ignores invalid packets, so we do */ DEBUG(10,("Received WINS-Replication packet was invalid, we just ignore it\n")); -- cgit v1.2.1