From a58c93318d592d931d232a1a25e37abdd27a825d Mon Sep 17 00:00:00 2001 From: Jones Syue Date: Fri, 1 Nov 2019 15:50:29 +0800 Subject: s3:libads: Fix mem leak in ads_create_machine_acct Use 'goto done' instead of 'return' to fix machine_escaped leak. Signed-off-by: Jones Syue Reviewed-by: Ralph Boehme Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Mon Nov 4 22:48:50 UTC 2019 on sn-devel-184 --- source3/libads/ldap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) mode change 100644 => 100755 source3/libads/ldap.c (limited to 'source3') diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c old mode 100644 new mode 100755 index 90d402abb4e..a630c5a0345 --- a/source3/libads/ldap.c +++ b/source3/libads/ldap.c @@ -2370,7 +2370,8 @@ ADS_STATUS ads_create_machine_acct(ADS_STRUCT *ads, /* Make sure to NULL terminate the array */ spn_array = talloc_realloc(ctx, spn_array, const char *, num_spns + 1); if (spn_array == NULL) { - return ADS_ERROR_LDAP(LDAP_NO_MEMORY); + ret = ADS_ERROR(LDAP_NO_MEMORY); + goto done; } spn_array[num_spns] = NULL; -- cgit v1.2.1