From 9ff5968a7f4ced23dc50b159545de71d227c47ab Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@samba.org>
Date: Sat, 11 Apr 2020 19:03:39 +0200
Subject: smbtree: Add "fail:" target, more failure paths with follow

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---
 source3/utils/smbtree.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

(limited to 'source3/utils')

diff --git a/source3/utils/smbtree.c b/source3/utils/smbtree.c
index e352bccb04d..847171ffef1 100644
--- a/source3/utils/smbtree.c
+++ b/source3/utils/smbtree.c
@@ -371,6 +371,8 @@ int main(int argc, char *argv[])
 		POPT_TABLEEND
 	};
 	poptContext pc;
+	int result = 1;
+
 
 	/* Initialise samba stuff */
 	smb_init_locale();
@@ -389,13 +391,14 @@ int main(int argc, char *argv[])
 	/* Now do our stuff */
 
         if (!print_tree(popt_get_cmdline_auth_info())) {
-		poptFreeContext(pc);
-		TALLOC_FREE(frame);
-                return 1;
+		goto fail;
 	}
 
 	popt_free_cmdline_auth_info();
+
+	result = 0;
+fail:
 	poptFreeContext(pc);
 	TALLOC_FREE(frame);
-	return 0;
+	return result;
 }
-- 
cgit v1.2.1