From 2a76f4d8c832155253be971975b0ac50649c7515 Mon Sep 17 00:00:00 2001 From: Derrell Lipman Date: Fri, 24 Oct 2008 10:26:56 -0400 Subject: Error return is False, not -1 - There were a few places in SMBC_getatr() that returned -1 instead of a boolean. -1 was intended to mean error, but that's what False is for, and the usages of this function assume that it returns a boolean with False as the error condition. Derrell --- source3/libsmb/libsmb_file.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'source3/libsmb/libsmb_file.c') diff --git a/source3/libsmb/libsmb_file.c b/source3/libsmb/libsmb_file.c index 7b287096c21..ece056db87f 100644 --- a/source3/libsmb/libsmb_file.c +++ b/source3/libsmb/libsmb_file.c @@ -518,7 +518,7 @@ SMBC_getatr(SMBCCTX * context, errno = EINVAL; TALLOC_FREE(frame); - return -1; + return False; } /* path fixup for . and .. */ @@ -527,14 +527,14 @@ SMBC_getatr(SMBCCTX * context, if (!fixedpath) { errno = ENOMEM; TALLOC_FREE(frame); - return -1; + return False; } } else { fixedpath = talloc_strdup(frame, path); if (!fixedpath) { errno = ENOMEM; TALLOC_FREE(frame); - return -1; + return False; } trim_string(fixedpath, NULL, "\\.."); trim_string(fixedpath, NULL, "\\."); -- cgit v1.2.1