From 398cb8a56d83a7978836ee0b65b4747d190ab630 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 26 Sep 2019 12:37:15 -0700 Subject: s3: smbd: Fix the SMB2 server to pass SMB2-PATH-SLASH. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [MS-FSA] 2.1.5.1 Server Requests an Open of a File Windows pathname specific processing. Always disallow trailing /, and also \\ on FILE_NON_DIRECTORY_FILE. We need to check this before the generic pathname parser as the generic pathname parser removes any trailing '/' and '\\'. Currently this is SMB2 only, but we could also add this check to the SMB1 NTCreateX calls if ultimately neded. Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme Autobuild-User(master): Ralph Böhme Autobuild-Date(master): Wed Oct 2 09:31:40 UTC 2019 on sn-devel-184 --- selftest/knownfail | 1 - 1 file changed, 1 deletion(-) (limited to 'selftest') diff --git a/selftest/knownfail b/selftest/knownfail index cd2323de3b3..82259dcfe90 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -10,7 +10,6 @@ ^samba3.smbtorture_s3.crypt_server\(nt4_dc\).SMB2-SESSION-RECONNECT # expected to give CONNECTION_DISCONNECTED, we need to fix the test ^samba3.smbtorture_s3.plain.*SMB2-DIR-FSYNC.*\(ad_dc_ntvfs\) ^samba3.smbtorture_s3.plain.*SMB2-PATH-SLASH.*\(ad_dc_ntvfs\) -^samba3.smbtorture_s3.plain.*SMB2-PATH-SLASH.*\(fileserver\) ^samba3.smbtorture_s3.plain.LOCK11.*\(ad_dc_ntvfs\) ^samba3.smb2.session enc.reconnect # expected to give CONNECTION_DISCONNECTED, we need to fix the test ^samba3.raw.session enc # expected to give ACCESS_DENIED as SMB1 encryption isn't used -- cgit v1.2.1