From 131bfc8ce2f04f1888e3d9a36f3ac65b70ef0e84 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Sun, 2 Feb 2020 20:57:17 +1300 Subject: selftest: avoid comparison against undefined value Signed-off-by: Douglas Bagnall Reviewed-by: Gary Lockyer Reviewed-by: Andrew Bartlett --- selftest/target/Samba3.pm | 4 +++- selftest/target/Samba4.pm | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'selftest') diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index 8786b320fa8..a3e2129b185 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -304,7 +304,9 @@ sub setup_nt4_member print "PROVISIONING MEMBER..."; my $require_mutexes = "dbwrap_tdb_require_mutexes:* = yes"; - $require_mutexes = "" if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} eq "1"); + if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} // '' eq "1") { + $require_mutexes = ""; + } my $member_options = " security = domain diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index 3fd70db4570..e181289b66b 100755 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -1790,7 +1790,9 @@ sub provision_ad_dc($$$$$$) my $conffile="$prefix_abs/etc/smb.conf"; my $require_mutexes = "dbwrap_tdb_require_mutexes:* = yes"; - $require_mutexes = "" if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} eq "1"); + if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} // '' eq "1") { + $require_mutexes = ""; + } my $config_h = {}; -- cgit v1.2.1