From bcd007532820a077320fe21f246c5ba0195e87d5 Mon Sep 17 00:00:00 2001 From: Tim Beale Date: Mon, 18 Feb 2019 15:34:51 +1300 Subject: selftest: Abort if we fail to startup testenv with '--one' option The --one selftest.pl option means abort when the first test fails. However, when 'make test' fails to startup a testenv, it'll try to continue and run other tests by default. When '--one' is used, selftest.pl can just die() at that point. Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett --- selftest/selftest.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'selftest/selftest.pl') diff --git a/selftest/selftest.pl b/selftest/selftest.pl index 9aea62a3d2a..ec44b89dac7 100755 --- a/selftest/selftest.pl +++ b/selftest/selftest.pl @@ -944,7 +944,11 @@ sub setup_env($$) $testenv_vars->{target} = $target; } if (not defined($testenv_vars)) { - warn("$opt_target can't start up known environment '$envname'"); + if ($opt_one) { + die("$opt_target can't start up known environment '$envname'"); + } else { + warn("$opt_target can't start up known environment '$envname'"); + } } } -- cgit v1.2.1