From 34f4491d79b47b2fe2457b8882f11644cf773bc4 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 28 Nov 2018 15:21:56 +0100 Subject: CVE-2018-14629 dns: fix CNAME loop prevention using counter regression The loop prevention should only be done for CNAME records! Otherwise we truncate the answer records for A, AAAA or SRV queries, which is a bad idea if you have more than 20 DCs. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600 Signed-off-by: Stefan Metzmacher Reviewed-by: Douglas Bagnall Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue Dec 4 08:52:29 CET 2018 on sn-devel-144 --- selftest/knownfail.d/dns | 6 ------ 1 file changed, 6 deletions(-) (limited to 'selftest/knownfail.d/dns') diff --git a/selftest/knownfail.d/dns b/selftest/knownfail.d/dns index 4bf01bdd89e..ec345372046 100644 --- a/selftest/knownfail.d/dns +++ b/selftest/knownfail.d/dns @@ -87,9 +87,3 @@ samba.tests.dns.__main__.TestSimpleQueries.test_one_SOA_query\(rodc:local\) ^samba.tests.dns.__main__.TestComplexQueries.test_cname_limit\(rodc:local\) ^samba.tests.dns.__main__.TestComplexQueries.test_cname_any_query\(vampire_dc:local\) ^samba.tests.dns.__main__.TestComplexQueries.test_cname_any_query\(rodc:local\) - -# These all fail until the next patch -^samba.tests.dns.__main__.TestComplexQueries.test_cname_limit -^samba.tests.dns.__main__.TestComplexQueries.test_record_limit_SRV -^samba.tests.dns.__main__.TestComplexQueries.test_record_limit_AAAA -^samba.tests.dns.__main__.TestComplexQueries.test_record_limit_A -- cgit v1.2.1