From 96472306bf13bd2a4d39d5fdd63a73f6140f8b44 Mon Sep 17 00:00:00 2001 From: Tim Beale Date: Mon, 18 Feb 2019 12:52:41 +1300 Subject: selftest: Add basic sanity-check tests for nopython target Previously we were only checking samba compiled OK with --disable-python, not that it actually ran. The main problem is all the make test framework is based around subunit/smbtorture, neither of which we seem to build with disable-python. However, for just a simple sanity-check, we can just bypass all the subunit-filter work and just call the Perl code directly. This works OK as long as it's just simple shell script tests that we're running, as we can check the script's exit code directly. The main thing that we really want to test is that we can start up the smbd testenv and connect to it (i.e. a simple smbclient test). This patch adds a new 'make test-nopython' target. This disables the subunit filtering, and runs a small test-list that was generated manually. Note that currently this has the limitation that it doesn't support known failures or flapping tests. However, just checking that smd starts up OK is probably OK for now. Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Feb 20 02:10:00 CET 2019 on sn-devel-144 --- script/autobuild.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'script') diff --git a/script/autobuild.py b/script/autobuild.py index f2a29497cf2..729f118019c 100755 --- a/script/autobuild.py +++ b/script/autobuild.py @@ -310,6 +310,7 @@ tasks = { ("configure", "./configure.developer --picky-developer ${PREFIX} --with-profiling-data --disable-python --without-ad-dc", "text/plain"), ("make", "make -j", "text/plain"), ("install", "make install", "text/plain"), + ("test", "make test-nopython", "text/plain"), ("check-clean-tree", "script/clean-source-tree.sh", "text/plain"), ("clean", "make clean", "text/plain"), @@ -343,6 +344,7 @@ tasks = { ("configure", "PYTHON=python2 ./configure.developer --picky-developer ${PREFIX} --with-profiling-data --disable-python --without-ad-dc", "text/plain"), ("make", "PYTHON=python2 make -j", "text/plain"), ("install", "PYTHON=python2 make install", "text/plain"), + ("test", "make test-nopython", "text/plain"), ("check-clean-tree", "script/clean-source-tree.sh", "text/plain"), ("clean", "PYTHON=python2 make clean", "text/plain"), -- cgit v1.2.1