From 57783d6295d1dcfcd4bd99951599c0765ae8c61b Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 12 Dec 2018 20:58:23 +0100 Subject: pidl: Fix unsigned integer comparison warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit bin/default/librpc/gen_ndr/py_wkssvc.c:27344:33: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long long unsigned int’ [-Wsign-compare] <--[gcc] if (test_var < 0 || test_var > uint_max) { ^ Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Thu Dec 13 05:00:20 CET 2018 on sn-devel-144 --- pidl/lib/Parse/Pidl/Samba4/Python.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pidl') diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm index 01dda41e63d..1ef64db14ee 100644 --- a/pidl/lib/Parse/Pidl/Samba4/Python.pm +++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm @@ -1726,7 +1726,7 @@ sub ConvertObjectFromPythonData($$$$$$;$$) $self->indent; $self->pidl("long test_var;"); $self->pidl("test_var = PyInt_AsLong($cvar);"); - $self->pidl("if (test_var < 0 || test_var > uint_max) {"); + $self->pidl("if (test_var < 0 || (unsigned long long)test_var > uint_max) {"); $self->indent; $self->pidl("PyErr_Format(PyExc_OverflowError, \"Expected type %s or %s within range 0 - %llu, got %ld\",\\"); $self->pidl(" PyInt_Type.tp_name, PyLong_Type.tp_name, uint_max, test_var);"); -- cgit v1.2.1