From dc82866dd76c043f73a93cde061af730cc010695 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Thu, 23 May 2019 13:56:39 +0000 Subject: nsswitch: cppcheck: Fix ctunullpointer error Fixes nsswitch/pam_winbind.c:1379: error: ctunullpointer: Null pointer dereference: info <--[cppcheck] Signed-off-by: Noel Power Reviewed-by: Andreas Schneider --- nsswitch/pam_winbind.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'nsswitch') diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index 0ba1955f007..7841377fdd6 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -1375,14 +1375,16 @@ static void _pam_set_data_string(struct pwb_context *ctx, static void _pam_set_data_info3(struct pwb_context *ctx, const struct wbcAuthUserInfo *info) { - _pam_set_data_string(ctx, PAM_WINBIND_HOMEDIR, + if (info != NULL) { + _pam_set_data_string(ctx, PAM_WINBIND_HOMEDIR, info->home_directory); - _pam_set_data_string(ctx, PAM_WINBIND_LOGONSCRIPT, + _pam_set_data_string(ctx, PAM_WINBIND_LOGONSCRIPT, info->logon_script); - _pam_set_data_string(ctx, PAM_WINBIND_LOGONSERVER, + _pam_set_data_string(ctx, PAM_WINBIND_LOGONSERVER, info->logon_server); - _pam_set_data_string(ctx, PAM_WINBIND_PROFILEPATH, + _pam_set_data_string(ctx, PAM_WINBIND_PROFILEPATH, info->profile_path); + } } /** -- cgit v1.2.1