From 4f65fa9c7b60264d71c8fe8ed715fb5c63e528ba Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 31 Mar 2016 14:41:07 +0200 Subject: pam_winbind: Avoid a use of sprintf pam_winbind depends on talloc, which depends on libreplace, so we have asprintf available. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- nsswitch/pam_winbind.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'nsswitch') diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index b2e1778c69d..42c4f8e5964 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -191,17 +191,17 @@ static void _pam_log_int(const pam_handle_t *pamh, { char *format2 = NULL; const char *service; + int ret; pam_get_item(pamh, PAM_SERVICE, (const void **) &service); - format2 = (char *)malloc(strlen(MODULE_NAME)+strlen(format)+strlen(service)+5); - if (format2 == NULL) { + ret = asprintf(&format2, "%s(%s): %s", MODULE_NAME, service, format); + if (ret == -1) { /* what else todo ? */ vsyslog(err, format, args); return; } - sprintf(format2, "%s(%s): %s", MODULE_NAME, service, format); vsyslog(err, format2, args); SAFE_FREE(format2); } -- cgit v1.2.1