From c692b5c95bdc0d96ab7797a59b94addaa1c80d94 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 28 Nov 2022 10:55:04 +0100 Subject: lib: Use talloc_asprintf_addbuf() in str_list_join_shell() This adds proper NULL checks via talloc_asprintf_addbuf() Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- lib/util/util_strlist.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'lib/util') diff --git a/lib/util/util_strlist.c b/lib/util/util_strlist.c index a1b80d464d5..e10200260fd 100644 --- a/lib/util/util_strlist.c +++ b/lib/util/util_strlist.c @@ -210,10 +210,11 @@ _PUBLIC_ char *str_list_join_shell(TALLOC_CTX *mem_ctx, const char **list, char ret = talloc_strdup(mem_ctx, list[0]); for (i = 1; list[i]; i++) { - if (strchr(list[i], ' ') || strlen(list[i]) == 0) - ret = talloc_asprintf_append_buffer(ret, "%c\"%s\"", sep, list[i]); - else - ret = talloc_asprintf_append_buffer(ret, "%c%s", sep, list[i]); + if (strchr(list[i], ' ') || strlen(list[i]) == 0) { + talloc_asprintf_addbuf(&ret, "%c\"%s\"", sep, list[i]); + } else { + talloc_asprintf_addbuf(&ret, "%c%s", sep, list[i]); + } } return ret; -- cgit v1.2.1