From 39b08c7c1ee2173e47c8e9d381b89c4d74a5e0f5 Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Tue, 3 Mar 2015 22:29:06 +0100 Subject: pyldb: Correct reference counting when returning bools Simply returning Py_True/PyFalse doesn't increment the bool object's reference count. Signed-off-by: Petr Viktorin Reviewed-by: Jelmer Vernooij Reviewed-by: Andrew Bartlett --- lib/ldb/pyldb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/ldb') diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c index 5bcff72a211..9bbd4ba66bc 100644 --- a/lib/ldb/pyldb.c +++ b/lib/ldb/pyldb.c @@ -457,7 +457,7 @@ static PyObject *py_ldb_dn_check_special(PyLdbDnObject *self, PyObject *args) if (!PyArg_ParseTuple(args, "s", &name)) return NULL; - return ldb_dn_check_special(self->dn, name)?Py_True:Py_False; + return PyBool_FromLong(ldb_dn_check_special(self->dn, name)); } static int py_ldb_dn_compare(PyLdbDnObject *dn1, PyLdbDnObject *dn2) @@ -507,7 +507,7 @@ static PyObject *py_ldb_dn_add_child(PyLdbDnObject *self, PyObject *args) if (!pyldb_Object_AsDn(NULL, py_other, dn_ldb_ctx(dn), &other)) return NULL; - return ldb_dn_add_child(dn, other)?Py_True:Py_False; + return PyBool_FromLong(ldb_dn_add_child(dn, other)); } static PyObject *py_ldb_dn_add_base(PyLdbDnObject *self, PyObject *args) @@ -522,7 +522,7 @@ static PyObject *py_ldb_dn_add_base(PyLdbDnObject *self, PyObject *args) if (!pyldb_Object_AsDn(NULL, py_other, dn_ldb_ctx(dn), &other)) return NULL; - return ldb_dn_add_base(dn, other)?Py_True:Py_False; + return PyBool_FromLong(ldb_dn_add_base(dn, other)); } static PyObject *py_ldb_dn_remove_base_components(PyLdbDnObject *self, PyObject *args) @@ -534,7 +534,7 @@ static PyObject *py_ldb_dn_remove_base_components(PyLdbDnObject *self, PyObject dn = pyldb_Dn_AsDn((PyObject *)self); - return ldb_dn_remove_base_components(dn, i)?Py_True:Py_False; + return PyBool_FromLong(ldb_dn_remove_base_components(dn, i)); } static PyObject *py_ldb_dn_is_child_of(PyLdbDnObject *self, PyObject *args) -- cgit v1.2.1