From 412afb2aef100e09eb433b8f0cae064fc2a736b7 Mon Sep 17 00:00:00 2001 From: Gary Lockyer Date: Fri, 24 May 2019 11:00:05 +1200 Subject: Fix ubsan null pointer passed as argument 2 Fix ubsan warning null pointer passed as argument 2 when the source pointer is NULL. The calls to memcpy are now guarded by an if (len > 0) Signed-off-by: Gary Lockyer Reviewed-by: Andreas Schneider Autobuild-User(master): Gary Lockyer Autobuild-Date(master): Mon May 27 01:29:48 UTC 2019 on sn-devel-184 --- lib/dbwrap/dbwrap_rbt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/dbwrap') diff --git a/lib/dbwrap/dbwrap_rbt.c b/lib/dbwrap/dbwrap_rbt.c index d9c743b80e8..145cfccf082 100644 --- a/lib/dbwrap/dbwrap_rbt.c +++ b/lib/dbwrap/dbwrap_rbt.c @@ -213,7 +213,9 @@ static NTSTATUS db_rbt_storev(struct db_record *rec, TALLOC_FREE(rec_priv->node); rec_priv->node = node; - memcpy(this_val.dptr, data.dptr, node->valuesize); + if (node->valuesize > 0) { + memcpy(this_val.dptr, data.dptr, node->valuesize); + } parent = NULL; p = &db_ctx->tree.rb_node; -- cgit v1.2.1