From 9ccf164550ab139edf123d00f68fd43d500d734c Mon Sep 17 00:00:00 2001 From: Gary Lockyer Date: Mon, 11 Dec 2017 09:36:08 +1300 Subject: ctdb/server/ctdb_daemon.c set socket close on exec Set SOCKET_CLOEXEC on the sockets returned by accept. This ensures that the socket is unavailable to any child process created by system(). Making it harder for malicious code to set up a command channel, as seen in the exploit for CVE-2015-0240 Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett --- ctdb/server/ctdb_daemon.c | 1 + 1 file changed, 1 insertion(+) (limited to 'ctdb') diff --git a/ctdb/server/ctdb_daemon.c b/ctdb/server/ctdb_daemon.c index 459dd2932ee..35c1ab639b5 100644 --- a/ctdb/server/ctdb_daemon.c +++ b/ctdb/server/ctdb_daemon.c @@ -949,6 +949,7 @@ static void ctdb_accept_client(struct tevent_context *ev, if (fd == -1) { return; } + smb_set_close_on_exec(fd); ret = set_blocking(fd, false); if (ret != 0) { -- cgit v1.2.1