From cdf8859b906bab0461256c7f773aba23227642df Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Tue, 4 May 2021 11:02:02 +0200 Subject: auth:creds: Check return code of cli_credentials_set_conf() Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- auth/credentials/pycredentials.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'auth') diff --git a/auth/credentials/pycredentials.c b/auth/credentials/pycredentials.c index 566405a08ee..7405704906a 100644 --- a/auth/credentials/pycredentials.c +++ b/auth/credentials/pycredentials.c @@ -622,6 +622,7 @@ static PyObject *py_creds_set_conf(PyObject *self, PyObject *args) struct loadparm_context *lp_ctx; TALLOC_CTX *mem_ctx; struct cli_credentials *creds; + bool ok; creds = PyCredentials_AsCliCredentials(self); if (creds == NULL) { @@ -645,9 +646,11 @@ static PyObject *py_creds_set_conf(PyObject *self, PyObject *args) return NULL; } - cli_credentials_set_conf(creds, lp_ctx); - + ok = cli_credentials_set_conf(creds, lp_ctx); talloc_free(mem_ctx); + if (!ok) { + return NULL; + } Py_RETURN_NONE; } -- cgit v1.2.1