From bac09f85daa6f610347fd467c27d1b5197b3a662 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 21 Mar 2019 16:38:35 +0100 Subject: idmap_hash: provide ID_TYPE_BOTH mappings also for unixids_to_sids While sids_to_unixids returns ID_TYPE_BOTH mappings, unixids_to_sids() returns the callers asked for, which fills gencache with the non ID_TYPE_BOTH mappings. As a result also the sids_to_unixids fast path via gencache won't return ID_TYPE_BOTH mappings. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15319 Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison (cherry picked from commit 9a24570d3d69f51b6d50bb04b739815ec67c1a3d) --- source3/winbindd/idmap_hash/idmap_hash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source3/winbindd/idmap_hash/idmap_hash.c b/source3/winbindd/idmap_hash/idmap_hash.c index d0bed7631a6..ec85119b063 100644 --- a/source3/winbindd/idmap_hash/idmap_hash.c +++ b/source3/winbindd/idmap_hash/idmap_hash.c @@ -224,6 +224,7 @@ static NTSTATUS unixids_to_sids(struct idmap_domain *dom, if (!hashed_domains[h_domain].sid) continue; + ids[i]->xid.type = ID_TYPE_BOTH; sid_compose(ids[i]->sid, hashed_domains[h_domain].sid, h_rid); ids[i]->status = ID_MAPPED; } -- cgit v1.2.1