From b7caabdb9e21974159e8a99e9741fafd8e7bdf2d Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Mon, 26 May 2014 15:48:34 +0200 Subject: libgpo: replace dup_sec_desc() usage Use security_descriptor_copy() instead, which is also provided by libcli. Signed-off-by: David Disseldorp Reviewed-by: Jeremy Allison --- libgpo/gpo_util.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libgpo/gpo_util.c b/libgpo/gpo_util.c index 5b801c4b086..e90b9a3f244 100644 --- a/libgpo/gpo_util.c +++ b/libgpo/gpo_util.c @@ -773,7 +773,13 @@ NTSTATUS gpo_copy(TALLOC_CTX *mem_ctx, } } - gpo->security_descriptor = dup_sec_desc(gpo, gpo_src->security_descriptor); + if (gpo_src->security_descriptor == NULL) { + /* existing SD assumed */ + TALLOC_FREE(gpo); + return NT_STATUS_INVALID_PARAMETER; + } + gpo->security_descriptor = security_descriptor_copy(gpo, + gpo_src->security_descriptor); if (gpo->security_descriptor == NULL) { TALLOC_FREE(gpo); return NT_STATUS_NO_MEMORY; -- cgit v1.2.1