From a44e4e932347c4c73bfcd9ee227a5105b5db09f2 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Mon, 4 Jan 2016 12:13:40 +1300 Subject: ldb: validate ldb_dn_set_component input parameters even more strictly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Bartlett Reviewed-by: Jelmer Vernooij Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Jan 6 00:33:21 CET 2016 on sn-devel-144 --- lib/ldb/common/ldb_dn.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c index a912fdb2a73..5bf72ac2f6b 100644 --- a/lib/ldb/common/ldb_dn.c +++ b/lib/ldb/common/ldb_dn.c @@ -1912,6 +1912,14 @@ int ldb_dn_set_component(struct ldb_dn *dn, int num, return LDB_ERR_OTHER; } + if (num < 0) { + return LDB_ERR_OTHER; + } + + if (v.length > v.length + 1) { + return LDB_ERR_OTHER; + } + n = talloc_strdup(dn, name); if ( ! n) { return LDB_ERR_OTHER; -- cgit v1.2.1