summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* gensec: Add a check if a gensec module implements weak cryptoAndreas Schneider2020-03-192-1/+13
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib:param: Add lp(cfg)_weak_crypto()Andreas Schneider2020-03-195-2/+40
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:utils: Add weak crypto information to testparmAndreas Schneider2020-03-192-0/+10
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib:crypto: Add samba_gnutls_weak_crypto()Andreas Schneider2020-03-193-0/+56
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* smbd: let delayed update handler also update on-disk timestampsRalph Boehme2020-03-192-10/+1
| | | | | | | | | | | | | | | | | | | | Let delayed update handler also update on-disk timestamps by calling trigger_write_time_update_immediate(). trigger_write_time_update_immediate() sets fsp->update_write_time_on_close to false which prevents updating the write-time on close if there was ever only one write to the file. Besides resetting fsp->update_write_time_on_close and setting the on-disk timestamps trigger_write_time_update_immediate() takes the same steps as the removed code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Mar 19 03:05:40 UTC 2020 on sn-devel-184
* smbd: let mark_file_modified() always call trigger_write_time_update()Ralph Boehme2020-03-191-2/+2
| | | | | | | | | | | | | | | Preperatory change: the next commit will reset fsp->update_write_time_on_close in the event handler, so this change ensures it gets set again for any subsequent write. This will NOT always result in a write-time update because trigger_write_time_update() has its own only-once logic using the internal variable fsp->update_write_time_triggered. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture/smb2: delayed timestamp updates test: more then one writeRalph Boehme2020-03-191-0/+116
| | | | | | | | | | | | | | | | | | | | | | Verify a close updates the write-time for subsequent writes after an initial write started the delayed update logic. This covers a scenario that will become relevant with the two subsequent commits. The next commit: smbd: let mark_file_modified() always call trigger_write_time_update() ensures that trigger_write_time_update() is not only called for the first write on a file. Without that preaparatory change, the second commit: smbd: let delayed update handler also update on-disk timestamps alone would cause this test to fail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture/smb2: delayed timestamp update test: single writeRalph Boehme2020-03-192-0/+87
| | | | | | | | | | | Verify close only updates write-time when a delayed update is actually pending. This scenario is not covered by basic.delaywrite. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: remove stat call from mark_file_modified()Ralph Boehme2020-03-191-3/+0
| | | | | | | | | | | This stat dates back to d03453864ab1bc5fd3b4a3abaf96176a006c102b where the call to trigger_write_time_update() had been to the file IO codepath. It was present there for other reasons: to setup the write-cache based on the file's size. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture/smb2: Windows 2019 15 ms timestamp resolutionRalph Boehme2020-03-193-0/+148
| | | | | | | | | | | | | | | | | | | | This test demonstrates that Windows has a timestamp resolution of ~15ms. When a smaller amount of time than that has passed between modifying operations on a file, it's not necessarily detectable on a Windows 2019 server that implements immediate timestamp updates (no delayed magic). Note that this test relies on a low latency SMB connection. Even with a low latency connection of eg 1m there's a chance of 1/15 that the first part of the test expecting no timestamp change fails as the writetime is updated. Due to this timing dependency this test is skipped in Samba CI, but it is preserved here for future SMB2 timestamps behaviour archealogists. See also: https://lists.samba.org/archive/cifs-protocol/2019-December/003358.html Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: flush pending writetime update when setting timestamps fileRalph Boehme2020-03-193-8/+22
| | | | | | | | | Cf the explanations in the previous commits. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: flush pending writetime update when flushing fileRalph Boehme2020-03-193-1/+14
| | | | | | | | | Cf the explanations in the previous commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: always flush pending write time update when setting filesizeRalph Boehme2020-03-192-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to flush a pending write time update even when we're setting the filesize to current filesize. Note that we're already doing it this way in the relevant places listed my dochelp@MS in https://lists.samba.org/archive/cifs-protocol/2019-December/003364.html Cleanup (= Close) SetBasicInfo SetAllocationInfo SetEndOfFileInfo SetValidDataLengthInfo Flush FSCTL_SET_ENCRYPTION FSCTL_OFFLOAD_WRITE Cleanup (= Close): Already implemented by update_write_time_on_close() and friends. SetBasicInfo: Currently doesn't flush pending updates. Fixed by a subsequent commit. SetAllocationInfo: smb_set_file_allocation_info() when setting a file's allocation size. SetEndOfFileInfo: Currently doesn't flush pending updates. Fixed by a subsequent commit. SetValidDataLengthInfo: Not implemented, returns NT_STATUS_NOT_SUPPORTED which seems wrong btw, as SetValidDataLengthInfo IS listed in MS-SMB2 2.2.39. Flush: Currently doesn't flush pending updates. Fixed by subsequent commit. FSCTL_SET_ENCRYPTION: Windows 2016 doesn't flush a pending writetime update, verified with a smbtorture test. FSCTL_OFFLOAD_WRITE: NT_STATUS_NOT_IMPLEMENTED BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture/smb2: add a test verifying a setinfo(basicinfo) flushes a pending ↵Ralph Boehme2020-03-192-0/+159
| | | | | | | | | writetime update BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture/smb2: add a test verifying a flush flushes a pending writetime updateRalph Boehme2020-03-192-0/+112
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture/smb2: mtime update logic with 2 handles: write io on handle 1, then ↵Ralph Boehme2020-03-192-0/+152
| | | | | | | | | set mtime on handle 2 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4/torture: fix a timestamps test to work on ext filesystemRalph Boehme2020-03-191-4/+4
| | | | | | | | | | | | | | | | | | | ext filesystem has a time_t limit of 15032385535 (0x0x37fffffff). From Documentation/filesystems/ext4/inodes.rst: If the inode structure size ``sb->s_inode_size`` is larger than 128 bytes and the ``i_inode_extra`` field is large enough to encompass the respective ``i_[cma]time_extra`` field, the ctime, atime, and mtime inode fields are widened to 64 bits. Within this “extra” 32-bit field, the lower two bits are used to extend the 32-bit seconds field to be 34 bit wide; the upper 30 bits are used to provide nanosecond timestamp accuracy. Therefore, timestamps should not overflow until May 2446. ... Changing the test to use the value 0x37fffffff instead of 100000000000 allows running the test locally on ext filesytems. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: enforce AIO requests drainingRalph Boehme2020-03-181-61/+7
| | | | | | | | | | | | | Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Mar 18 19:40:00 UTC 2020 on sn-devel-184
* Revert "s3: VFS: vfs_default: Add tevent_req pointer to state struct in ↵Jeremy Allison2020-03-181-2/+0
| | | | | | | | | | | | | | vfswrap_pread_state." This reverts commit 594a435b33e8447625ca83b50daec2d08cf66d64. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default. Pass in struct vfswrap_pread_state as the ↵Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | | | callback data to the subreq." This reverts commit e102908f112866d657b8c0cd6a5b217d070210c8. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default. Protect vfs_pread_done() from accessing a ↵Jeremy Allison2020-03-181-20/+0
| | | | | | | | | | | | | | freed req pointer." This reverts commit b9ad06079fe362385cc4c77f8e8d54f5f74d6db6. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default: Add tevent_req pointer to state struct in ↵Jeremy Allison2020-03-181-2/+0
| | | | | | | | | | | | | | vfswrap_pwrite_state." This reverts commit 86cc7439501ab9b9eb018a18dbbef9567eb9b6f9. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default. Pass in struct vfswrap_pwrite_state as the ↵Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | | | callback data to the subreq." This reverts commit 13e25d68385aa951115e0e063ec6a9a281fea4a4. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default. Protect vfs_pwrite_done() from accessing a ↵Jeremy Allison2020-03-181-20/+0
| | | | | | | | | | | | | | freed req pointer." This reverts commit c8cd93dd54cb9f78665928d4bc8fcc3baf084b6f. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default: Add tevent_req pointer to state struct in ↵Jeremy Allison2020-03-181-2/+0
| | | | | | | | | | | | | | vfswrap_fsync_state." This reverts commit 4adde71b99d4ab09914072458329d5f1008b77e3. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default. Pass in struct vfswrap_fsync_state as the ↵Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | | | callback data to the subreq." This reverts commit d623779913e0d4a46d7e299dc41b5c83cb127872. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_default. Protect vfs_fsync_done() from accessing a ↵Jeremy Allison2020-03-181-20/+0
| | | | | | | | | | | | | | freed req pointer." This reverts commit 18671534e42f66b904e51c3fbe887e998ff79493. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs: Add tevent_req pointer to state struct in ↵Jeremy Allison2020-03-181-2/+0
| | | | | | | | | | | | | | vfs_gluster_pread_state." This reverts commit 0e3dc0078ebd6aa79553bf2afa8e72945e23dfb0. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs. Pass in struct vfs_gluster_pread_state as ↵Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | | | the callback data to the subreq." This reverts commit c6c4e2de22cd3d84f45f5c21e6b09b09274f7f7b. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs. Protect vfs_gluster_pread_done() from ↵Jeremy Allison2020-03-181-20/+0
| | | | | | | | | | | | | | accessing a freed req pointer." This reverts commit 99283871c5230e640a8102943ebed685459ed9af. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs: Add tevent_req pointer to state struct in ↵Jeremy Allison2020-03-181-2/+0
| | | | | | | | | | | | | | vfs_gluster_pwrite_state." This reverts commit 058a7effd00b47e4778f7d680cc9c2a7d40d5fa8. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs. Pass in struct vfs_gluster_pwrite_state as ↵Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | | | the callback data to the subreq." This reverts commit 3357a77d0823eddc1b0db68cfa251a0d54058c88. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs. Protect vfs_gluster_pwrite_done() from ↵Jeremy Allison2020-03-181-20/+0
| | | | | | | | | | | | | | accessing a freed req pointer." This reverts commit 67910c751c9f5ce8cdd1e57b34e51e5b7163838b. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs: Add tevent_req pointer to state struct in ↵Jeremy Allison2020-03-181-2/+0
| | | | | | | | | | | | | | vfs_gluster_fsync_state." This reverts commit c0c088b1b786f0ba248960114191277e91bbba2f. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs. Pass in struct vfs_gluster_fsync_state as ↵Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | | | the callback data to the subreq." This reverts commit cdde55a69d0dacd2f9939c2f00cd356c0186f791. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "s3: VFS: vfs_glusterfs. Protect vfs_gluster_fsync_done() from ↵Jeremy Allison2020-03-181-20/+0
| | | | | | | | | | | | | | accessing a freed req pointer." This reverts commit 9ecbda263f102a24257fd47142b7c24d1f429d8d. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "vfs_default: pass in state as the callback data to the subreq"Jeremy Allison2020-03-181-4/+5
| | | | | | | | | | | | This reverts commit 0e894f3e48285415f72cf7a68e26f1802fe8045d. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Revert "vfs_default: Protect vfs_getxattrat_done() from accessing a freed ↵Jeremy Allison2020-03-181-19/+0
| | | | | | | | | | | | | | req pointer" This reverts commit 95cfcda13fe9a70b9955a7c44173d619eacb34c1. Now we wait for all aio to finish on all SHUTDOWN_CLOSE cases, this is no longer needed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Remove file_close_pid().Jeremy Allison2020-03-182-19/+0
| | | | | | | | | The old synchronous reply_exit() was the only user. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Remove old synchronous SMB1 reply_exit().Jeremy Allison2020-03-181-10/+21
| | | | | | | | | SMB1 exit is now fully async. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Add async internals of reply_exit().Jeremy Allison2020-03-181-0/+201
| | | | | | | | | | | | | | | | | | | | Waits until all aio requests on all fsp's owned by this vuid are finished before returning to the client. Charges the profile time in the done function. Not strictly correct but better than the other SMB1 async code that double-charges profiling in both send and done at the moment. Done this way (commented out) so it is a clean diff and it's clear what is being added. A later commit will remove the old synchronous version. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Remove old synchronous SMB1 reply_ulogoffX().Jeremy Allison2020-03-181-27/+21
| | | | | | | | | SMB1 user logoff is now fully async. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: reply_ulogoffX() Update to modern coding standards.Jeremy Allison2020-03-181-2/+2
| | | | | | | | | Minimizes the diff in the later commits. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: In reply_ulogoffX(), replace req -> smb1req.Jeremy Allison2020-03-181-11/+11
| | | | | | | | | Minimises the diff in later commits. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Add async internals of reply_ulogoffX.Jeremy Allison2020-03-181-0/+168
| | | | | | | | | | | | | | | | | | | | Waits until all aio requests on all fsp's owned by this vuid are finished before returning to the client. Charges the profile time in the done function. Not strictly correct but better than the other SMB1 async code that double-charges profiling in both send and done at the moment. Done this way (commented out) so it is a clean diff and it's clear what is being added. A later commit will remove the old synchronous version. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Remove old synchronous SMB1 reply_tdis().Jeremy Allison2020-03-181-26/+19
| | | | | | | | | SMB1 tree disconnect is now fully async. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: reply_tdis() Update to modern coding standards.Jeremy Allison2020-03-181-2/+2
| | | | | | | | | Minimizes the diff in the next commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: In reply_tdis(), replace req -> smb1req.Jeremy Allison2020-03-181-6/+6
| | | | | | | | | Minimises the diff in the next commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Add async internals of reply_tdis().Jeremy Allison2020-03-181-0/+173
| | | | | | | | | | | | | | | | | | | | Waits until all aio requests on all fsp's under this conn struct are finished before returning to the client. Charges the profile time in the done function. Not strictly correct but better than the other SMB1 async code that double-charges profiling in both send and done at the moment. Done this way (commented out) so it is a clean diff and it's clear what is being added. A later commit will remove the old synchronous version. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Replace synchronous conn_force_tdis() with the async version.Jeremy Allison2020-03-181-28/+16
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
View Lorry Controller Status