diff options
| author | Garming Sam <garming@catalyst.net.nz> | 2017-03-29 13:16:48 +1300 |
|---|---|---|
| committer | Garming Sam <garming@samba.org> | 2017-04-13 07:29:18 +0200 |
| commit | b10ee68600bbdf51d71d9b46edbc4de846955580 (patch) | |
| tree | 2e4f353c753fa0dfa96f9866801e133fe86252c3 /source4/dsdb/dns/dns_update.c | |
| parent | 58113e5bc954aba470e1d240d74d7210e9a22dca (diff) | |
| download | samba-b10ee68600bbdf51d71d9b46edbc4de846955580.tar.gz | |
rodc/dns: Do not put a trailing dot at end of a DNS record
This causes RESOLV_WRAPPER to not detect the record correctly (while
also creating inconsistent and possibly breaking records).
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4/dsdb/dns/dns_update.c')
| -rw-r--r-- | source4/dsdb/dns/dns_update.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/source4/dsdb/dns/dns_update.c b/source4/dsdb/dns/dns_update.c index 0591e346824..959223dc6f8 100644 --- a/source4/dsdb/dns/dns_update.c +++ b/source4/dsdb/dns/dns_update.c @@ -531,36 +531,35 @@ static NTSTATUS dnsupdate_dnsupdate_RODC(struct irpc_message *msg, return NT_STATUS_OK; } - for (i=0; i<st->r->in.dns_names->count; i++) { struct NL_DNS_NAME_INFO *n = &r->in.dns_names->names[i]; switch (n->type) { case NlDnsLdapAtSite: - dprintf(st->fd, "SRV _ldap._tcp.%s._sites.%s. %s %u\n", + dprintf(st->fd, "SRV _ldap._tcp.%s._sites.%s %s %u\n", site, dnsdomain, hostname, n->port); break; case NlDnsGcAtSite: - dprintf(st->fd, "SRV _ldap._tcp.%s._sites.gc._msdcs.%s. %s %u\n", + dprintf(st->fd, "SRV _ldap._tcp.%s._sites.gc._msdcs.%s %s %u\n", site, dnsdomain, hostname, n->port); break; case NlDnsDsaCname: - dprintf(st->fd, "CNAME %s._msdcs.%s. %s\n", + dprintf(st->fd, "CNAME %s._msdcs.%s %s\n", ntdsguid, dnsforest, hostname); break; case NlDnsKdcAtSite: - dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.dc._msdcs.%s. %s %u\n", + dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.dc._msdcs.%s %s %u\n", site, dnsdomain, hostname, n->port); break; case NlDnsDcAtSite: - dprintf(st->fd, "SRV _ldap._tcp.%s._sites.dc._msdcs.%s. %s %u\n", + dprintf(st->fd, "SRV _ldap._tcp.%s._sites.dc._msdcs.%s %s %u\n", site, dnsdomain, hostname, n->port); break; case NlDnsRfc1510KdcAtSite: - dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.%s. %s %u\n", + dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.%s %s %u\n", site, dnsdomain, hostname, n->port); break; case NlDnsGenericGcAtSite: - dprintf(st->fd, "SRV _gc._tcp.%s._sites.%s. %s %u\n", + dprintf(st->fd, "SRV _gc._tcp.%s._sites.%s %s %u\n", site, dnsforest, hostname, n->port); break; } |