diff options
| author | Andreas Schneider <asn@samba.org> | 2018-01-11 09:23:05 +0100 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2018-01-15 17:48:18 +0100 |
| commit | 264249db0f5515d8333d16218f1553ae9f0e7193 (patch) | |
| tree | ed7cdbb90c73254e62a0d3266b44449638aacc51 /source3 | |
| parent | 0d62579a41fc4a04c299ec8a3537bf5db149149b (diff) | |
| download | samba-264249db0f5515d8333d16218f1553ae9f0e7193.tar.gz | |
s3:winbindd: Improve logic so it is easier to understand
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/winbindd/winbindd_pam.c | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c index de3e3f5cc81..f60a90ceb18 100644 --- a/source3/winbindd/winbindd_pam.c +++ b/source3/winbindd/winbindd_pam.c @@ -1683,22 +1683,24 @@ static NTSTATUS winbindd_dual_pam_auth_samlogon( true, /* interactive */ &authoritative, &info3); - if (NT_STATUS_IS_OK(result)) { - result = map_info3_to_validation(mem_ctx, - info3, - &validation_level, - &validation); - TALLOC_FREE(info3); - if (!NT_STATUS_IS_OK(result)) { - goto done; - } - } /* * We need to try the remote NETLOGON server if this is * not authoritative (for example on the RODC). */ if (authoritative != 0) { + if (NT_STATUS_IS_OK(result)) { + result = map_info3_to_validation( + mem_ctx, + info3, + &validation_level, + &validation); + TALLOC_FREE(info3); + if (!NT_STATUS_IS_OK(result)) { + goto done; + } + } + goto done; } } |