diff options
| author | Ralph Boehme <slow@samba.org> | 2018-04-30 19:03:41 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2018-05-04 00:11:24 +0200 |
| commit | d3b9d11bade8bc52d08688ee66a4a20fe0a31a04 (patch) | |
| tree | c839b76e93f96fc6c0e468ed3d8e6e14486adabb /source3/smbd/server.c | |
| parent | a753ccfd946aaad320977ae8c5f483f73077c3f8 (diff) | |
| download | samba-d3b9d11bade8bc52d08688ee66a4a20fe0a31a04.tar.gz | |
s3:cleanupd: use MSG_SMB_BRL_VALIDATE to signal cleanupd unclean process shutdown
Since 6423ca4bf293cac5e2f84b1a37bb29b06b5c05ed messaging_send_all()
broadcasts messages in a cluster, so cleanupd receives those broadcasts
and acts upon it by re-broadcasting the message. Result: message
storm.
By reactivating the currently unused MSG_SMB_BRL_VALIDATE for the
trigger message to cleanupd we avoid the storm.
Note that MSG_SMB_BRL_VALIDATE was unused only in the sense that noone
*listened* to it, but we were still *sending* the message in
smbd_parent_ctdb_reconfigured(). de6fe2a1dd6ab03b1c369b61da17fded72305b2d
removed listening for MSG_SMB_BRL_VALIDATE from cleanupd. This commits
brings it back.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13414
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/smbd/server.c')
| -rw-r--r-- | source3/smbd/server.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/server.c b/source3/smbd/server.c index e7e297f1f18..07d7136ef41 100644 --- a/source3/smbd/server.c +++ b/source3/smbd/server.c @@ -757,7 +757,7 @@ static void cleanup_timeout_fn(struct tevent_context *event_ctx, parent->cleanup_te = NULL; messaging_send_buf(parent->msg_ctx, parent->cleanupd, - MSG_SMB_UNLOCK, NULL, 0); + MSG_SMB_BRL_VALIDATE, NULL, 0); } static void cleanupd_started(struct tevent_req *req) |