diff options
| author | Noel Power <noel.power@suse.com> | 2019-05-23 13:56:39 +0000 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2019-06-04 22:13:07 +0000 |
| commit | dc82866dd76c043f73a93cde061af730cc010695 (patch) | |
| tree | a07859ed74588e845ced848b87c21896f235742d /nsswitch | |
| parent | a0ccec6291a219ded9b1a86ddaa18a61456699da (diff) | |
| download | samba-dc82866dd76c043f73a93cde061af730cc010695.tar.gz | |
nsswitch: cppcheck: Fix ctunullpointer error
Fixes
nsswitch/pam_winbind.c:1379: error: ctunullpointer: Null pointer dereference: info <--[cppcheck]
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'nsswitch')
| -rw-r--r-- | nsswitch/pam_winbind.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index 0ba1955f007..7841377fdd6 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -1375,14 +1375,16 @@ static void _pam_set_data_string(struct pwb_context *ctx, static void _pam_set_data_info3(struct pwb_context *ctx, const struct wbcAuthUserInfo *info) { - _pam_set_data_string(ctx, PAM_WINBIND_HOMEDIR, + if (info != NULL) { + _pam_set_data_string(ctx, PAM_WINBIND_HOMEDIR, info->home_directory); - _pam_set_data_string(ctx, PAM_WINBIND_LOGONSCRIPT, + _pam_set_data_string(ctx, PAM_WINBIND_LOGONSCRIPT, info->logon_script); - _pam_set_data_string(ctx, PAM_WINBIND_LOGONSERVER, + _pam_set_data_string(ctx, PAM_WINBIND_LOGONSERVER, info->logon_server); - _pam_set_data_string(ctx, PAM_WINBIND_PROFILEPATH, + _pam_set_data_string(ctx, PAM_WINBIND_PROFILEPATH, info->profile_path); + } } /** |