summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2020-02-27 11:27:17 +1300
committerAndrew Bartlett <abartlet@samba.org>2020-02-28 03:08:46 +0000
commit48cfb8458b0ff86e3a431240933caa02d64af82f (patch)
tree1c64dc511151313a1d6ec9be48da39a5ae19a55a
parent0a87f59ac2580bdb7f93efa075323c73fc1ec83e (diff)
downloadsamba-48cfb8458b0ff86e3a431240933caa02d64af82f.tar.gz
ldb: Improve coding style in ldb_kv_index_dn_simple()
We avoid bare if conditions in Samba. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14299 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
-rw-r--r--lib/ldb/ldb_key_value/ldb_kv_index.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/ldb/ldb_key_value/ldb_kv_index.c b/lib/ldb/ldb_key_value/ldb_kv_index.c
index 4701bf92f68..2935b95c4dd 100644
--- a/lib/ldb/ldb_key_value/ldb_kv_index.c
+++ b/lib/ldb/ldb_key_value/ldb_kv_index.c
@@ -1282,7 +1282,9 @@ static int ldb_kv_index_dn_simple(struct ldb_module *module,
* as ltdb_search_indexed will filter out the wrong one in
* ltdb_index_filter() which calls ldb_match_message().
*/
- if (!dn) return LDB_ERR_OPERATIONS_ERROR;
+ if (!dn) {
+ return LDB_ERR_OPERATIONS_ERROR;
+ }
ret = ldb_kv_dn_list_load(module, ldb_kv, dn, list,
DN_LIST_WILL_BE_READ_ONLY);