summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2020-02-24 10:30:26 +1300
committerAndrew Bartlett <abartlet@samba.org>2020-02-28 03:08:46 +0000
commit47b6c4b8f5987adda861bf8440949df4aaacef6c (patch)
treeb9b310947178809218a657f021eeda63ab684ac6
parent7ad56d41740d6794a85889f268654564c48c8a74 (diff)
downloadsamba-47b6c4b8f5987adda861bf8440949df4aaacef6c.tar.gz
dsdb: Improve clarity by adding a comment in replmd_delete_internals()
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
-rw-r--r--source4/dsdb/samdb/ldb_modules/repl_meta_data.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 3395e6395ac..824a4612f5a 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -4664,6 +4664,11 @@ static int replmd_delete_internals(struct ldb_module *module, struct ldb_request
el->name,
ldb_attr_cmp,
attr);
+ /*
+ * If we are preserving, do not do the
+ * ldb_msg_add_empty() below, continue
+ * to the next element
+ */
if (attr != NULL) {
continue;
}