diff options
| author | Noel Power <noel.power@suse.com> | 2019-05-24 13:37:00 +0000 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2020-01-10 11:56:20 +0100 |
| commit | 030fa9e5455125e30b71c90be80baadb657d8993 (patch) | |
| tree | d1fa844739ab859a3ed5679b3975ba4df2abf79d | |
| parent | 16b377276ee82c04d069666e53deaa95a7633dd4 (diff) | |
| download | samba-030fa9e5455125e30b71c90be80baadb657d8993.tar.gz | |
CVE-2019-14907 lib/util/charset: clang: Fix Value stored to 'reason' is never read warning
Fixes:
lib/util/charset/convert_string.c:301:5: warning: Value stored to 'reason' is never read <--[clang]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14208
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer gary@catalyst.net.nz
(cherry picked from commit add47e288bc80c1bf45765d1588a9fa5998ea677)
| -rw-r--r-- | lib/util/charset/convert_string.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/util/charset/convert_string.c b/lib/util/charset/convert_string.c index 196302aacfd..34facab6fe6 100644 --- a/lib/util/charset/convert_string.c +++ b/lib/util/charset/convert_string.c @@ -300,13 +300,13 @@ bool convert_string_handle(struct smb_iconv_handle *ic, { reason="No more room"; if (from == CH_UNIX) { - DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u - '%s'\n", + DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u - '%s' error: %s\n", charset_name(ic, from), charset_name(ic, to), - (unsigned int)srclen, (unsigned int)destlen, (const char *)src)); + (unsigned int)srclen, (unsigned int)destlen, (const char *)src, reason)); } else { - DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u\n", + DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u error: %s\n", charset_name(ic, from), charset_name(ic, to), - (unsigned int)srclen, (unsigned int)destlen)); + (unsigned int)srclen, (unsigned int)destlen, reason)); } break; } |