delta/samba.git/libcli/drsuapi, branch master

libcli:drsuapi: Fix code spelling

2023-04-27T14:25:38+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

tests: Fix "-Werror=maybe-uninitialized" errors only seen with -O3 and --enable-coverage

2021-04-28T03:43:34+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

smbdes: convert sam_rid_crypt() to use gnutls

2019-12-10T00:30:30+00:00

Signed-off-by: Isaac Boukris 
Reviewed-by: Andrew Bartlett

build: Do not build selftest binaries for builds without --enable-selftest

2019-11-22T11:48:59+00:00

Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()

This allows us to be much more consistent (at least in the core Samba)
and documents clearly why the binary should not be installed.

Not modified are
 - test_lp_load
 - notifyd-tests
 - gendrandperf
 - test* from examples/libsmbclient
 - dbwrap_torture
 - split_tokens
 - locktest2
 - msgtest
 - msg_sink
 - msg_source
 - versiontest
 - rpc_open_tcp
 - test_headers

As these are not tested in selftest so any change would also be
untested.  Of course they probably should be added in a different
MR.

Also not modified (because they are not tests, nor part of the
build system) are:
 - smb2mount
 - notifydd
 - log2pacp
 - debug2html
 - smbfilter
 - destroy_netlogon_creds_cli
 - spotlight2*
 - tevent_glib_tracker

These do however appear to be untested.

For now, the source4 forked client tools are left unchanged:
 - smbclient4
 - nmblookup4

Finally, the heimdal binaries are left as install=False as
they are either part of the build system or end-user tools
that we just don't want to install.  These are however tested.

The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
correct but are not needed if the selftest is not run on MacOS.

There are likely other platforms or build environments where building
our test binaries is more pain than valuable, see for example also
https://lists.samba.org/archive/samba/2019-November/227137.html

Signed-off-by: Andrew Bartlett 
Reviewed-by: Isaac Boukris 

Autobuild-User(master): Isaac Boukris 
Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184

lib/crypto: Use GnuTLS RC4 for samba_gnutls_arcfour_confounded_md5()

2019-06-27T12:54:23+00:00

This allows Samba to use GnuTLS for drsuapi_{en,de}crypt_attribute_value()

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

liblic/drsupai: use samba_gnutls_arcfour_confounded_md5() wrapper

2019-06-27T12:54:23+00:00

This common code will reduce duplication, particularly when we move
arcfour_encrypt_buffer() calls to GnuTLS

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

libcli/drsuapi: Correct comment in drsuapi_decrypt_attribute_value()

2019-06-27T12:54:23+00:00

This is not a copy, it is just a pointer assignment.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

libcli/drsuapi: Add expected value unit tests for drsuapi_{en,de}crypt_attribute_value()

2019-06-27T12:54:22+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

libcli/drsuapi: Add const to *in parameters to drsuapi_{en,de}crypt_attribute_value()

2019-06-27T12:54:22+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

libcli/drsuapi: Make drsuapi_decrypt_attribute_value() static

2019-06-27T12:54:22+00:00

The last external user was removed in 0980a3471ed8fcc3a37296857285dc0235e0e0d2 in 2010

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider