delta/samba.git/lib, branch master

lib:audit_logging: Fix typo in log message

2023-05-18T01:03:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:audit_logging: Add function to add a formatted time value to a JSON message

2023-05-18T01:03:37+00:00

json_add_timestamp() is limited to adding a ‘timestamp’ field with the
current time. The new function can add an arbitrary timestamp with an
arbitrary field name.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:audit_logging: Add function to add an optional boolean value to a JSON message

2023-05-18T01:03:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:audit_logging: Add function to add flags to a JSON message

2023-05-18T01:03:37+00:00

This replaces a couple of calls to snprintf() in
log_authentication_event_json() and log_successful_authz_event_json()
respectively.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

python: Safely clear structure members

2023-05-16T23:29:32+00:00

Using Py_CLEAR() ensures that these structures are observed in a
consistent state by any Python code that may run during deconstruction.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:util: prefer size_t for random data generation functions

2023-05-16T23:29:32+00:00

Prefer 'size_t' over 'int' in generate_random_buffer(),
generate_secret_buffer() and generate_nonce_buffer() to
match an underlying gnutls_rnd() calls.

Signed-off-by: Dmitry Antipov 
Reviewed-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

param: Add new parameter "ad dc functional level"

2023-05-16T23:29:32+00:00

This allows the new unsupported functional levels to be unlocked, but with an smb.conf
option that is easily seen.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Joseph Sutton

lib:ldb: do not offset against NULL pointer in ldb_ldif_read()

2023-05-09T01:59:32+00:00

Fix the following error observed running samba.test.registry
compiled with clang-17 and UBsan:

lib/ldb/common/ldb_ldif.c:881:9: runtime error: applying non-zero offset 137438953440 to null pointer
    #0 0x7faa0eb3932f in ldb_ldif_read lib/ldb/common/ldb_ldif.c:881
    #1 0x7faa0eb3aec6 in ldb_ldif_read_string lib/ldb/common/ldb_ldif.c:1004
    #2 0x7faa077ed759 in dsdb_set_schema_from_ldif source4/dsdb/schema/schema_set.c:1113
    #3 0x7faa068fcbbf in py_dsdb_set_schema_from_ldif source4/dsdb/pydsdb.c:929
    #4 0x7faa1d1d4507 in cfunction_call (/lib64/libpython3.11.so.1.0+0x1d4507)
    [... a lot of Python calls skipped...]

I.e. number of elements should be checked against zero
before making an attempt to access an element by index.

Signed-off-by: Dmitry Antipov 
Reviewed-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:addns: Don’t call memcpy() with a NULL pointer

2023-05-05T02:54:31+00:00

Doing so is undefined behaviour.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib:util: Fix undefined bitshift

2023-05-05T02:54:31+00:00

runtime error: left shift of 65535 by 16 places cannot be represented in type 'int'

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett