diff options
author | Daniel RodrÃguez Troitiño <drodrigueztroitino@yahoo.es> | 2009-10-08 08:48:34 +0200 |
---|---|---|
committer | Christian Neukirchen <chneukirchen@gmail.com> | 2009-10-18 21:37:09 +0200 |
commit | 5945b587f9f0ac349f4159b26e521d072c552bb2 (patch) | |
tree | 429c061c5c565ef7ae653752ecab38df470756cc | |
parent | f22a0818cbc06be23fab1e0246c226af058b56bc (diff) | |
download | rack-5945b587f9f0ac349f4159b26e521d072c552bb2.tar.gz |
Test multipart upload with a semicolon in the name.
Test a multipart upload in which the specified
filename includes a semicolon. Should be parsed
with the included filename, but Rack stops at the
filename.
Signed-off-by: Christian Neukirchen <chneukirchen@gmail.com>
-rw-r--r-- | test/multipart/semicolon | 6 | ||||
-rw-r--r-- | test/spec_rack_utils.rb | 12 |
2 files changed, 18 insertions, 0 deletions
diff --git a/test/multipart/semicolon b/test/multipart/semicolon new file mode 100644 index 00000000..00fd68ab --- /dev/null +++ b/test/multipart/semicolon @@ -0,0 +1,6 @@ +--AaB03x
+Content-Disposition: form-data; name="files"; filename="fi;le1.txt"
+Content-Type: text/plain
+
+contents
+--AaB03x--
\ No newline at end of file diff --git a/test/spec_rack_utils.rb b/test/spec_rack_utils.rb index 94366418..f270e87e 100644 --- a/test/spec_rack_utils.rb +++ b/test/spec_rack_utils.rb @@ -329,6 +329,18 @@ context "Rack::Utils::Multipart" do params["files"][:tempfile].read.should.equal "" end + specify "should parse multipart upload with filename with semicolons" do + env = Rack::MockRequest.env_for("/", multipart_fixture(:semicolon)) + params = Rack::Utils::Multipart.parse_multipart(env) + params["files"][:type].should.equal "text/plain" + params["files"][:filename].should.equal "fi;le1.txt" + params["files"][:head].should.equal "Content-Disposition: form-data; " + + "name=\"files\"; filename=\"fi;le1.txt\"\r\n" + + "Content-Type: text/plain\r\n" + params["files"][:name].should.equal "files" + params["files"][:tempfile].read.should.equal "contents" + end + specify "should not include file params if no file was selected" do env = Rack::MockRequest.env_for("/", multipart_fixture(:none)) params = Rack::Utils::Multipart.parse_multipart(env) |